Add CacaoZcapProof2022 #436
Conversation
src/cacao_zcap/mod.rs
Outdated
|
|
||
| mod core; | ||
| pub use self::core::*; | ||
| #[cfg(feature = "cacao-zcap")] |
There was a problem hiding this comment.
You can remove this #[cfg(...)] statement as the entire module is already enabled for this feature.
src/cacao_zcap/mod.rs
Outdated
| /* Can't call zcap.verify yet because that depends on ssi | ||
| * having this proof type. | ||
| use crate::vc::Check; | ||
| let res = zcap.verify(None, &resolver).await; | ||
| assert_eq!(res.errors, Vec::<String>::new()); | ||
| assert!(res.checks.iter().any(|c| c == &Check::Proof)); | ||
| */ | ||
|
|
||
| /* Can't verify because signature is not real | ||
| let proof = zcap.proof.as_ref().unwrap(); | ||
| let warnings = CacaoZcapProof2022 | ||
| .verify(proof, &zcap, &resolver) | ||
| .await | ||
| .unwrap(); | ||
| dbg!(warnings); | ||
| */ |
There was a problem hiding this comment.
Can this be uncommented now that it has been added as a proof type?
There was a problem hiding this comment.
Updated the comment in e1cbf6c
The second part "Can't verify because signature is not real" is still true; a real signed test vector will need to be created to actually test verify. examples/cacao-zcap-regenerate-test-vectors.rs could be updated to do that.
Partially uncomment, as a negative test.
|
|
|
Closing as ssi has been majorly refactored since this PR was opened and we do not need this feature currently |
Importing code and test vectors from https://github.com/spruceid/cacao-zcap-rs.
To have ssi depend on the cacao-zcap crate as it is now would create a circular dependency, since cacao-zcap already depends on ssi. This PR therefore adds the cacao-zcap implementation into the ssi crate directly.
To reduce the coupling so that cacao-zcap (and other proof suites) could be separate from the ssi crate, would require some refactoring. e.g. a "core" part of ssi could be removed into a new crate that the proof suites could depend on, so that ssi could depend on the proof suites as separate crates.
The context file has already been added (#434) - Although it is not needed for just a CacaoZcapProof2022 delegation which does not itself involve JSON-LD processing, it is needed to invoke the delegation with a different (JSON-LD) proof type.
Note: embedding a CacaoProof2022/CacaoZcapProof2022 delegation in an invocation or subdelegation doesn't yet work, because of #437.