Enable secp256k1 and p256 by default #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyc
approved these changes
Apr 9, 2021
|
Fine by me, I think we should open up as much functionality as we can for users out of the box, and we can taper to specific environments as necessary (or provide guides to do so). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #138, in order to provide the most functionality we can for the Universal Resolver, it would be useful to enable secp256k1 and p256 features for the
didkit-httpDocker image. As mentioned in #138 (comment), these features are currently not enabled by default. I think it would be good to make these default features fordidkit,didkit-cli, anddidkit-http, so that users are not surprised by missing functionality. The features should remain opt-out-able via disablingdefault-features.