chore: linter

spring6225 · Jun 8, 2022 · 76cd035 · 76cd035
1 parent e5bb702
commit 76cd035
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/apps/rush/src/start.ts b/apps/rush/src/start.ts
@@ -24,10 +24,9 @@ import * as semver from 'semver';
 
 import {
   ConsoleTerminalProvider,
-  Terminal,
   Text,
   PackageJsonLookup,
-  ITerminal
+  ITerminalProvider
 } from '@rushstack/node-core-library';
 import { EnvironmentVariableNames } from '@microsoft/rush-lib';
 import * as rushLib from '@microsoft/rush-lib';
@@ -89,9 +88,9 @@ if (rushVersionToLoad && semver.lt(rushVersionToLoad, '5.0.0-dev.18')) {
 // Rush is "managed" if its version and configuration are dictated by a repo's rush.json
 const isManaged: boolean = !!configuration;
 
-const terminal: ITerminal = new Terminal(new ConsoleTerminalProvider());
+const terminalProvider: ITerminalProvider = new ConsoleTerminalProvider();
 
-const launchOptions: rushLib.ILaunchOptions = { isManaged, alreadyReportedNodeTooNewError, terminal };
+const launchOptions: rushLib.ILaunchOptions = { isManaged, alreadyReportedNodeTooNewError, terminalProvider };
 
 // If we're inside a repo folder, and it's requesting a different version, then use the RushVersionManager to
 // install it

diff --git a/common/reviews/api/rush-lib.api.md b/common/reviews/api/rush-lib.api.md
@@ -338,6 +338,7 @@ export interface ILaunchOptions {
     // @internal
     builtInPluginConfigurations?: _IBuiltInPluginConfiguration[];
     isManaged: boolean;
+    terminalProvider?: ITerminalProvider;
 }
 
 // @beta (undocumented)

diff --git a/libraries/rush-lib/src/cli/RushPnpmCommandLine.ts b/libraries/rush-lib/src/cli/RushPnpmCommandLine.ts
@@ -18,7 +18,6 @@ import { RushConfiguration } from '../api/RushConfiguration';
 import { NodeJsCompatibility } from '../logic/NodeJsCompatibility';
 import { SpawnSyncReturns } from 'child_process';
 import { ILaunchOptions } from '../api/Rush';
-import { InstallHelpers } from '../logic/installManager/InstallHelpers';
 
 export interface ILaunchRushPnpmInternalOptions extends ILaunchOptions {}
 
@@ -71,7 +70,7 @@ export class RushPnpmCommandLine {
     process.exitCode = 1;
 
     const { terminalProvider } = options;
-    const terminal = new Terminal(terminalProvider || new ConsoleTerminalProvider());
+    const terminal: ITerminal = new Terminal(terminalProvider || new ConsoleTerminalProvider());
 
     try {
       // Are we in a Rush repo?