Merge pull request microsoft#4074 from chengcyber/fix-look-by-path

Fix look by path

common/changes/@microsoft/rush/fix-look-by-path_2023-04-25-09-41.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/rush",
+      "comment": "Fix an issue where the last character in a project's path is ignored when determining which files contribute to the project's cache ID.",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush"
+}

libraries/rush-lib/src/logic/LookupByPath.ts

@@ -111,7 +111,7 @@ export class LookupByPath<TItem> {
     }
 
     // Last segment
-    if (previousIndex + 1 < input.length) {
+    if (previousIndex < input.length) {
       yield {
         prefix: input.slice(previousIndex, input.length),
         index: input.length

libraries/rush-lib/src/logic/test/LookupByPath.test.ts

@@ -20,6 +20,10 @@ describe(LookupByPath.iteratePathSegments.name, () => {
     const result = [...LookupByPath.iteratePathSegments('foo/bar/baz')];
     expect(result).toEqual(['foo', 'bar', 'baz']);
   });
+  it('returns correct last single character segment', () => {
+    const result = [...LookupByPath.iteratePathSegments('foo/a')];
+    expect(result).toEqual(['foo', 'a']);
+  });
 });
 
 describe(LookupByPath.prototype.findChildPath.name, () => {