Merge pull request microsoft#4026 from iclanton/fix-plugin-installation

[rush] Fix an issue where rush plugin autoinstallers would fail to install because the Rush global folder had not yet been initialized.
spring6225 · Mar 22, 2023 · 2e36264 · 2e36264
2 parents f4626cc + 0ace1a5
commit 2e36264
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/common/changes/@microsoft/rush/fix-plugin-installation_2023-03-22-19-55.json b/common/changes/@microsoft/rush/fix-plugin-installation_2023-03-22-19-55.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/rush",
+      "comment": "Fix an issue where rush plugin autoinstallers would fail to install because the Rush global folder had not yet been initialized.",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush"
+}
diff --git a/libraries/rush-lib/src/cli/RushCommandLineParser.ts b/libraries/rush-lib/src/cli/RushCommandLineParser.ts
@@ -66,7 +66,7 @@ export interface IRushCommandLineParserOptions {
 
 export class RushCommandLineParser extends CommandLineParser {
   public telemetry: Telemetry | undefined;
-  public rushGlobalFolder!: RushGlobalFolder;
+  public rushGlobalFolder: RushGlobalFolder;
   public readonly rushConfiguration!: RushConfiguration;
   public readonly rushSession: RushSession;
   public readonly pluginManager: PluginManager;
@@ -127,6 +127,8 @@ export class RushCommandLineParser extends CommandLineParser {
       rushConfiguration: this.rushConfiguration
     });
 
+    this.rushGlobalFolder = new RushGlobalFolder();
+
     this.rushSession = new RushSession({
       getIsDebugMode: () => this.isDebug,
       terminalProvider: this._terminalProvider
@@ -239,8 +241,6 @@ export class RushCommandLineParser extends CommandLineParser {
 
   private _populateActions(): void {
     try {
-      this.rushGlobalFolder = new RushGlobalFolder();
-
       // Alphabetical order
       this.addAction(new AddAction(this));
       this.addAction(new ChangeAction(this));