Merge pull request microsoft#4068 from dmichon-msft/rush-version-work…

…space-perf [rush] Fix rush version `workspace:*` perf
spring6225 · Apr 21, 2023 · 14f9259 · 14f9259
2 parents 63304a8 + 0a0cce7
commit 14f9259
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 7 deletions.
diff --git a/common/changes/@microsoft/rush/rush-version-workspace-perf_2023-04-20-22-52.json b/common/changes/@microsoft/rush/rush-version-workspace-perf_2023-04-20-22-52.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/rush",
+      "comment": "Fix a performance bug in `rush version` when using `workspace:` protocol.",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush"
+}
diff --git a/libraries/rush-lib/src/logic/PublishUtilities.ts b/libraries/rush-lib/src/logic/PublishUtilities.ts
@@ -779,14 +779,16 @@ export class PublishUtilities {
       const isWorkspaceWildcardVersion: boolean =
         requiredVersion.specifierType === DependencySpecifierType.Workspace &&
         requiredVersion.versionSpecifier === '*';
-      const alwaysUpdate: boolean =
-        (!!prereleaseToken &&
-          prereleaseToken.hasValue &&
-          !allChanges.packageChanges.has(parentPackageName)) ||
-        isWorkspaceWildcardVersion;
+
+      const isPrerelease: boolean =
+        !!prereleaseToken && prereleaseToken.hasValue && !allChanges.packageChanges.has(parentPackageName);
 
       // If the version range exists and has not yet been updated to this version, update it.
-      if (requiredVersion.versionSpecifier !== change.newRangeDependency || alwaysUpdate) {
+      if (
+        isPrerelease ||
+        isWorkspaceWildcardVersion ||
+        requiredVersion.versionSpecifier !== change.newRangeDependency
+      ) {
         let changeType: ChangeType | undefined;
         // Propagate hotfix changes to dependencies
         if (change.changeType === ChangeType.hotfix) {
@@ -815,7 +817,7 @@ export class PublishUtilities {
           projectsToExclude
         });
 
-        if (hasChanges || alwaysUpdate) {
+        if (hasChanges || isPrerelease) {
           // Only re-evaluate downstream dependencies if updating the parent package's dependency
           // caused a version bump.
           hasChanges =