Skip to content

Conversation

dfuenzalida
Copy link
Contributor

This PR fixes a typo in the text of the submit button of the visits form causing the label of the button to be missing.

Validation

Before:

$ curl -s http://localhost:8080/owners/6/pets/8/visits/new | grep submit
        <button class="btn btn-primary" type="submit"></button>

After (note the "Add Visit" text):

$ curl -s http://localhost:8080/owners/6/pets/8/visits/new | grep submit
        <button class="btn btn-primary" type="submit">Add Visit</button>

@dfuenzalida dfuenzalida changed the title Fix typo in visits form which caused button to miss its text Fix typo in visits form which causes button to miss its text Jun 8, 2025
@dsyer
Copy link
Member

dsyer commented Jun 13, 2025

LGTM. You need to sign the commit though.

@dfuenzalida
Copy link
Contributor Author

dfuenzalida commented Jun 14, 2025

LGTM. You need to sign the commit though.

Hi @dsyer, thanks for reviewing. I've updated the commit to include the sign-off.

@dsyer dsyer merged commit f9399b7 into spring-projects:main Jun 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants