Skip to content

Internationalization Enhancement #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

Internationalization Enhancement #1878

merged 1 commit into from
May 6, 2025

Conversation

anizmo
Copy link
Contributor

@anizmo anizmo commented May 1, 2025

Commit Contents:

  • Added test to ensure there are no string literals
  • Added test to ensure a string is translated in all language files
  • Added missing strings in properties
  • Internationalized remaining strings flagged by the tests

Context:

  • This makes it easier to enforce that we always follow internationalization, and a preventive approach works better than searching and fixing individual strings later.
  • This test flagged each missing string for me, and I was able to resolve each one of them.

@anizmo
Internationalization Enhancement
0882b8b 
- Added test to ensure there are no string literals
- Added test to ensure a string is translated in all language files
- Added missing strings in properties
- Internationalized remaining strings flagged by the tests

Signed-off-by: anizmo <[email protected]>
@anizmo anizmo force-pushed the validate-internationalization-for-all-pages branch from eb9ed38 to 0882b8b Compare May 1, 2025 01:57
@anizmo
Copy link
Contributor Author

anizmo commented May 5, 2025 •
edited
Loading

Could someone please assist me in merging this? This one is approved, but I don't see an option to merge it.
FYI @dsyer

@dsyer dsyer merged commit c5af32d into spring-projects:main May 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@andrzejsydor andrzejsydor andrzejsydor approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anizmo @andrzejsydor @dsyer