Refactor doGetBeanNamesForType for improved readability and performance #35503
+81
−57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
This pull request refactors the logic for collecting bean names by type in
DefaultListableBeanFactory
to improve readability and maintainability. The main change is splitting the logic into two helper methods: one for processing bean definitions and another for processing manually registered singletons. This makes the code easier to follow and maintain, without altering its functionality.Refactoring and code organization:
processBeanDefinitions
(handles bean definitions) andprocessManualSingletons
(handles manually registered singletons), improving separation of concerns and code readability.Error handling improvements:
Note
This helps with hot path configuration at the jit computer level.
Thank you for reviewing this PR! Your feedback is highly appreciated.