Update TestRestTemplate's default cookie handling to match RestTemplate's#49261
Open
apoorvdarshan wants to merge 1 commit intospring-projects:mainfrom
Open
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
…te's Signed-off-by: Apoorv Darshan <ad13dtu@gmail.com>
apoorvdarshan
force-pushed
the
fix/testresttemplate-default-cookie-handling
branch
from
dff9449 to
7e42613
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StandardCookieSpec.IGNORE), differing from RestTemplate which uses the HTTP client library's defaultwithCookies(HttpCookies)method for explicit cookie control, following the same pattern aswithRedirects(HttpRedirects)from Align TestRestTemplate default redirect settings to be the same as RestTemplate #43431HttpCookiesenum,HttpComponentsCookieSpecadapter, andcookies()onRestTemplateBuilderHttpClientOption.ENABLE_COOKIESFixes gh-48607
Test plan
TestRestTemplateTests— verifies default cookie spec is now null (library default),withCookies(ENABLE)returns"strict",withCookies(DISABLE)returns"ignoreCookies"HttpClientSettingsTests— verifieswithCookies()and updatedorElse()with cookies fieldHttpClientAutoConfigurationTests— verifies settings construction with new record shape