Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NamedChannel model to core module #89

Merged

Conversation

onobc
Copy link
Collaborator

@onobc onobc commented Jan 5, 2025

This commit introduces the NamedChannelRegistry which allows moving the NamedChannel model to the core package and decouples it from the client properties.

@onobc onobc requested a review from dsyer January 5, 2025 23:21
@onobc onobc added this to the 0.3.0 milestone Jan 5, 2025
|spring.grpc.client.default-channel.ssl.bundle | | SSL bundle name.
|spring.grpc.client.default-channel.ssl.enabled | | Whether to enable SSL support. Enabled automatically if "bundle" is provided unless specified otherwise.
|spring.grpc.client.default-channel.user-agent | | The custom User-Agent for the channel.
|spring.grpc.client.default-channel.address | |
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to look into why this is not finding the default any longer. I have an idea but you can ignore this part of the code for the review for now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsyer I manually adjusted the props for now so as to not block this PR merge. I will fix this in subsequent PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracked here #92

@dsyer
Copy link
Collaborator

dsyer commented Jan 6, 2025

LGTM

This commit introduces the NamedChannelRegistry which allows
moving the NamedChannel model to the core package and decouples
it from the client properties.
@onobc onobc force-pushed the refactor-named-channels2 branch from 50cc0fd to e1d2ee3 Compare January 7, 2025 03:06
@onobc onobc merged commit c936d6a into spring-projects-experimental:main Jan 7, 2025
1 check passed
@onobc onobc deleted the refactor-named-channels2 branch January 7, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants