Remove HTTP/2 :status pseudo header if added by downstream HTTP client #3369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencergibb
reviewed
Apr 22, 2024
|
|
||
| @Override | ||
| public HttpHeaders apply(HttpHeaders input, ServerResponse serverResponse) { | ||
| if (input.containsKey(":status")) { |
There was a problem hiding this comment.
Should we check that it is actually an http2 request, or is the presence of the :status pseudo-header enough?
There was a problem hiding this comment.
From my tests, if JDK HttpClient is used and that the downstream exchange is done in http2, the :status header will be forwarded upstream not matter the HTTP version.
Only difference is that in http1.1 it will still work, while it will crash in http2.
So from my understanding it's better to always remove it as it should never be part of the real headers anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-3326
N.B: For the order of the filter I don't know what is the rule ?
I took the same value as RemoveContentLengthRequestHeadersFilter since it seemed to be a similar kind of filter (but for response instead of request)