Register Applications: update validation rule name

Resolves #770
spring-cloud · May 4, 2018 · 55a202c · 55a202c
1 parent 7a58b86
commit 55a202c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/ui/src/app/apps/apps-register/apps-register.component.spec.ts b/ui/src/app/apps/apps-register/apps-register.component.spec.ts
@@ -92,7 +92,7 @@ describe('AppsRegisterComponent', () => {
     it('should display an error if no the name is invalid', () => {
       const tests = [
         {name: '', type: 'source', uri: 'http://foo.bar', metaDataUri: '', force: false},
-        {name: 'foo bar', type: 'sink', uri: 'http://foo.bar', metaDataUri: '', force: false}
+        {name: 'd', type: 'sink', uri: 'http://foo.bar', metaDataUri: '', force: false}
       ];
       const form = component.forms[0];
       tests.forEach((test) => {

diff --git a/ui/src/app/apps/apps-register/apps-register.validator.spec.ts b/ui/src/app/apps/apps-register/apps-register.validator.spec.ts
@@ -11,16 +11,17 @@ describe('AppsRegisterValidator', () => {
   describe('appName', () => {
 
     it('invalid', () => {
-      [' ', 'f', 'fo ', 'foo>', 'foo.', 'foo/', 'foo?', 'foo{', 'foo}', 'foo^', 'foo$', 'foo#', 'foo@', 'foo*',
-        'foo(', 'foo)', 'foo[', 'foo]', 'foo<', 'foo>', 'foo,', 'foo!', 'foo|', 'foo bar'].forEach((mock) => {
+      [' ', 'f'].forEach((mock) => {
         const appName: FormControl = new FormControl(mock);
         const result = AppsRegisterValidator.appName(appName);
         expect(result.invalid).toBeTruthy();
       });
     });
 
     it('valid', () => {
-      [null, 'fo', 'foo', 'f12', 'foo12', 'foooooooooooooooooooooooooo'].forEach((mock) => {
+      [null, 'fo', 'foo', 'f12', 'foo12', 'foooooooooooooooooooooooooo', 'fo ', 'foo>', 'foo.', 'foo/', 'foo?', 'foo-',
+        'foo{', 'foo}', 'foo^', 'foo$', 'foo#', 'foo@', 'foo*', 'foo(', 'foo)', 'foo[', 'foo]', 'foo<', 'foo>',
+        'foo,', 'foo!', 'foo|', 'foo bar'].forEach((mock) => {
         const appName: FormControl = new FormControl(mock);
         const result = AppsRegisterValidator.appName(appName);
         expect(result).toBeNull();

diff --git a/ui/src/app/apps/apps-register/apps-register.validator.ts b/ui/src/app/apps/apps-register/apps-register.validator.ts
@@ -11,7 +11,7 @@ export class AppsRegisterValidator {
   /**
    * Name regex
    */
-  static nameRegex = /^[a-zA-Z0-9]{2,50}$/;
+  static nameRegex = /^.{2,250}$/;
 
   /**
    * Uri regex