-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update gemfile #400
base: main
Are you sure you want to change the base?
update gemfile #400
Conversation
@@ -6,7 +6,11 @@ def method_type | |||
end | |||
|
|||
def payment_source_class | |||
Check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to lack of CheckSerializer error:
NameError: Spree::Api::V2::Platform::PaymentSerializer cannot resolve a serializer class for 'Spree::Check'. Attempted to find 'Spree::Api::V2::Platform::CheckSerializer'. Consider specifying the serializer directly through options[:serializer].
I found out that in this case nil
should be returned and source shouldn't be required:
https://github.com/spree/spree/blob/main/core/app/models/spree/payment_method.rb#L34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KacperMekarski we cannot change this to nil, we need to add that serializer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍
@@ -6,7 +6,11 @@ def method_type | |||
end | |||
|
|||
def payment_source_class | |||
Check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KacperMekarski we cannot change this to nil, we need to add that serializer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2 Case has been resolved.
No major conflict has been found in data. |
No description provided.