-
Notifications
You must be signed in to change notification settings - Fork 523
Upgrade to Beam 2.70 #5867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upgrade to Beam 2.70 #5867
Conversation
|
it seems that the libraries-bom bump somehow broke our AutoValue processor in scio-smb edit: isolated it to some change between libraries-bom 26.66.0 -> 26.67.0 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5867 +/- ##
=======================================
Coverage 61.53% 61.53%
=======================================
Files 317 317
Lines 11662 11662
Branches 850 850
=======================================
Hits 7176 7176
Misses 4486 4486 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| val sparkMajorVersion = VersionNumber(sparkVersion).numbers.take(1).mkString(".") | ||
|
|
||
| // check recommended versions from libraries-bom | ||
| // https://storage.googleapis.com/cloud-opensource-java-dashboard/com.google.cloud/libraries-bom/26.65.0/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was sadly removed :(
|
|
||
| public abstract TryWrapper failure(Throwable throwable); | ||
|
|
||
| // Set to arbitrarily high value; required to preserve timestamp of original element |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed this one in #5806
| "org.slf4j" % "slf4j-api" % slf4jVersion, | ||
| "com.google.auto.value" % "auto-value-annotations" % autoValueVersion, | ||
| // provided | ||
| "com.google.auto.value" % "auto-value" % autoValueVersion % Provided, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is providing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's the recommendation of the AutoValue user guide to mark this as provided - it's used to generate the AutoValue classes in our compilation phase, but downstream consumers of Scio don't actually need it in their compile classpath!
No description provided.