Skip to content

Conversation

@clairemcginty
Copy link
Contributor

No description provided.

@clairemcginty
Copy link
Contributor Author

clairemcginty commented Jan 7, 2026

it seems that the libraries-bom bump somehow broke our AutoValue processor in scio-smb

edit: isolated it to some change between libraries-bom 26.66.0 -> 26.67.0

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.53%. Comparing base (11f87a1) to head (2a92658).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5867   +/-   ##
=======================================
  Coverage   61.53%   61.53%           
=======================================
  Files         317      317           
  Lines       11662    11662           
  Branches      850      850           
=======================================
  Hits         7176     7176           
  Misses       4486     4486           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

val sparkMajorVersion = VersionNumber(sparkVersion).numbers.take(1).mkString(".")

// check recommended versions from libraries-bom
// https://storage.googleapis.com/cloud-opensource-java-dashboard/com.google.cloud/libraries-bom/26.65.0/index.html
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was sadly removed :(


public abstract TryWrapper failure(Throwable throwable);

// Set to arbitrarily high value; required to preserve timestamp of original element
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed this one in #5806

"org.slf4j" % "slf4j-api" % slf4jVersion,
"com.google.auto.value" % "auto-value-annotations" % autoValueVersion,
// provided
"com.google.auto.value" % "auto-value" % autoValueVersion % Provided,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is providing it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the recommendation of the AutoValue user guide to mark this as provided - it's used to generate the AutoValue classes in our compilation phase, but downstream consumers of Scio don't actually need it in their compile classpath!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants