-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exec] Fixed multiple event inputs #187
base: develop
Are you sure you want to change the base?
Conversation
7c2d898
to
25ff120
Compare
Hi @gfalcone ! Thanks for taking the time to make this PR, and sorry for the long delay in replying! While the proposed change makes sense to me, I am having trouble reproducing this error - can you tell me how you are using the inputs in your |
Hello @fallonchen no problem :). It happened on Python 3.6 and Apache Beam 2.27 (which is not the version used at the moment by Klio if I am not wrong). If I recall, I was following the example on this page : https://docs.klio.io/en/stable/userguide/pipeline/io.html#step-2-using-multiple-inputs |
Hello @fallonchen, do you have any news concerning this PR ? Thank you :) |
Hey @gfalcone - sorry for the silence! I'm going to close then reopen this PR to re-trigger the GitHub actions. If this still passes, I'll go ahead and merge, and it should be available in either the |
fixed a separate bug that had the build broken, so let's try this re-triggering workflows again 😅 |
uff, okay - hey @gfalcone could I ask you to rebase this PR off of latest |
25ff120
to
0a6bebd
Compare
Hello @econchick , first of all sorry for the late reply :/. I rebased my branch with develop, it should be good now. Thank you for your help on this :) |
Hello !
I have an error when I use multiple event inputs like this in my Klio job :
Here is the error I get when I do a
klio job run
:I have successfully ran my jobs with this fix.
Thank you in advance for taking a look into it :)
Checklist for PR author(s)
[cli] Fixes bugs in 'klio job fake-cmd'
.docs/src
.docs/src/reference/<package>/changelog.rst
.