Resolve final get resources issue #1166 #1191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#1166 Earlier changes were based off descriptions provided which didn't indicate there was a difference between how plexus worked by looking at direct files vs files on classpath. Make this much clearer and avoid plexus entirely as its internals just do nio now. Keep rest of logic which confirms classpath side of things with existing tests.
|
|
This appears to be side effect of original code that was not defined to work. The resource manager is provided all it needs from the direct project its sitting in, it doesn't know about the parent so its logic to copy didn't work out in case file is on disk in parent location but not listed on sub modules. An integration test provided to fix this has been tweaked and added to the project here. The logic around this handling has been documented to be handling files vs URL which restores prior behavior and prevents its removal now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1166