Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yt-dlp Extractor Argument Support #2285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kyrluckechuck
Copy link

@Kyrluckechuck Kyrluckechuck commented Jan 24, 2025

Add yt-dlp Extractor Argument Support

Adds yt-dlp extractor argument support

Description

Youtube has recently made it impossible to use yt-dlp without accessing via PO Tokens. yt-dlp supports that, but you need to be able to provide the extractor_args parameter to the API (or --extractor-args to the CLI).

This PR enables that in the Spotdl API since if you were to supply it currently it would fail.

** Note
This does not add the support to the CLI usage (yet), as that isn't in the scope of what I use this library for. A followup enabling this through the CLI & argument parser would be necessary to enable those. This fix is sufficient for my usage.

Related Issue

Partially fixes #2279, depending on if you're using the CLI or API

Motivation and Context

See description

How Has This Been Tested?

Locally, doing simple tests.

Screenshots (if appropriate)

Before (with cookies only):
image

After (with cookies & po token):
image

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookies Not Working for High-Quality Audio Downloads in Spotdl; PO Tokens Required in YTDLP
1 participant