-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1296 from spotDL/dev
* Various improvements (#1295) * Some Code Cleanup (#1275) * Bump version number to 3.6.1 Co-authored-by: Jakub Kot <[email protected]> Co-authored-by: Peyton Creery <[email protected]> Co-authored-by: AZMCode <[email protected]> Co-authored-by: Aiden Gardner <[email protected]> Co-authored-by: Oliver Blanthorn <[email protected]> Co-authored-by: Andrzej Klajnert <[email protected]>
- Loading branch information
Showing
43 changed files
with
2,093 additions
and
1,953 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # Set the default behavior, in case people don't have core.autocrlf set. | ||
| * text=auto eol=lf | ||
|
|
||
| # Explicitly declare text files you want to always be normalized and converted | ||
| # to native line endings on checkout. | ||
| *.py text diff=python | ||
|
|
||
| # Documents | ||
| *.md text diff=markdown | ||
|
|
||
| # Graphics | ||
| *.png binary | ||
| *.jpg binary | ||
| *.jpeg binary | ||
| *.gif binary | ||
| *.svg text | ||
|
|
||
| # Scripts | ||
| *.bash text eol=lf | ||
| *.fish text eol=lf | ||
| *.sh text eol=lf | ||
| # These are explicitly windows files and should use crlf | ||
| *.bat text eol=crlf | ||
| *.cmd text eol=crlf | ||
|
|
||
| # Serialisation | ||
| *.json text | ||
| *.toml text | ||
| *.xml text | ||
| *.yaml text | ||
| *.yml text | ||
|
|
||
| # Exclude files from exporting | ||
| .gitattributes export-ignore | ||
| .gitignore export-ignore | ||
| .gitkeep export-ignore |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,63 +1,63 @@ | ||
| --- | ||
| about: Report bugs so we can fix them. | ||
| assignees: '' | ||
| labels: bug | ||
| name: Bug report | ||
| title: Change this title, Poorly Formatted Issues will not be handled. | ||
| --- | ||
|
|
||
| <!--- Please search existing bugs before creating a new one --> | ||
|
|
||
| <!--- Format your issue titles as 'Error: Description' --> | ||
|
|
||
| <!--- example title: "FileNotFoundError: error while downloading individual songs." --> | ||
|
|
||
| <!--- You can also talk to us on our Discord https://discord.gg/xCa23pwJWY --> | ||
|
|
||
| ### Environment | ||
|
|
||
| - **System OS:** <!--- Windows/OSX/Linux/Heroku/Docker --> | ||
|
|
||
| - **Python Version:** <!--- Python Version can be found by running "py -V" --> | ||
|
|
||
| - **Install Source:** | ||
|
|
||
| <!--- Did you download from pip, or from GitHub? --> | ||
|
|
||
| <!--- Provide the command you used to install spotDL --> | ||
|
|
||
| - **Version OR Commit hash:** | ||
|
|
||
| <!--- If from pip, what is the version? Run "pip show spotdl" --> | ||
|
|
||
| <!--- If not from pip, what is the commit hash? --> | ||
|
|
||
| ______________________________________________________________________ | ||
|
|
||
| ### Expected Behaviour | ||
|
|
||
| <!--- What did you expect to happen? --> | ||
|
|
||
| ### Actual Behaviour | ||
|
|
||
| <!--- What actually happened? --> | ||
|
|
||
| ### Steps to Reproduce | ||
|
|
||
| 1. | ||
| 2. | ||
| 3. | ||
|
|
||
| ______________________________________________________________________ | ||
|
|
||
| ### Traceback | ||
|
|
||
| <!--- Place traceback here, between the ``` symbols --> | ||
|
|
||
| ``` | ||
| ``` | ||
|
|
||
| ______________________________________________________________________ | ||
|
|
||
| ### Any other information: | ||
| --- | ||
| about: Report bugs so we can fix them. | ||
| assignees: '' | ||
| labels: bug | ||
| name: Bug report | ||
| title: Change this title, Poorly Formatted Issues will not be handled. | ||
| --- | ||
|
|
||
| <!--- Please search existing bugs before creating a new one --> | ||
|
|
||
| <!--- Format your issue titles as 'Error: Description' --> | ||
|
|
||
| <!--- example title: "FileNotFoundError: error while downloading individual songs." --> | ||
|
|
||
| <!--- You can also talk to us on our Discord https://discord.gg/xCa23pwJWY --> | ||
|
|
||
| ### Environment | ||
|
|
||
| - **System OS:** <!--- Windows/OSX/Linux/Heroku/Docker --> | ||
|
|
||
| - **Python Version:** <!--- Python Version can be found by running "py -V" --> | ||
|
|
||
| - **Install Source:** | ||
|
|
||
| <!--- Did you download from pip, or from GitHub? --> | ||
|
|
||
| <!--- Provide the command you used to install spotDL --> | ||
|
|
||
| - **Version OR Commit hash:** | ||
|
|
||
| <!--- If from pip, what is the version? Run "pip show spotdl" --> | ||
|
|
||
| <!--- If not from pip, what is the commit hash? --> | ||
|
|
||
| ______________________________________________________________________ | ||
|
|
||
| ### Expected Behaviour | ||
|
|
||
| <!--- What did you expect to happen? --> | ||
|
|
||
| ### Actual Behaviour | ||
|
|
||
| <!--- What actually happened? --> | ||
|
|
||
| ### Steps to Reproduce | ||
|
|
||
| 1. | ||
| 2. | ||
| 3. | ||
|
|
||
| ______________________________________________________________________ | ||
|
|
||
| ### Traceback | ||
|
|
||
| <!--- Place traceback here, between the ``` symbols --> | ||
|
|
||
| ``` | ||
| ``` | ||
|
|
||
| ______________________________________________________________________ | ||
|
|
||
| ### Any other information: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,21 @@ | ||
| --- | ||
| about: Request a feature to be added to spotDL! | ||
| assignees: '' | ||
| labels: feature-request | ||
| name: Feature Request | ||
| title: Change this title, Poorly Formatted Requests will not be handled. | ||
| --- | ||
|
|
||
| <!--- Please search existing issues for your feature before creating a new one --> | ||
|
|
||
| <!--- Change the title to summarise simply and succintly. --> | ||
|
|
||
| <!--- !!! Come talk to us on our Discord! https://discord.gg/xCa23pwJWY !!! --> | ||
|
|
||
| ## Problem | ||
|
|
||
| <!--- Why should we add this feature? How would it help spotDL users? --> | ||
|
|
||
| ## Solution | ||
|
|
||
| <!--- Describe a solution or implementation, if you have one. --> | ||
| --- | ||
| about: Request a feature to be added to spotDL! | ||
| assignees: '' | ||
| labels: feature-request | ||
| name: Feature Request | ||
| title: Change this title, Poorly Formatted Requests will not be handled. | ||
| --- | ||
|
|
||
| <!--- Please search existing issues for your feature before creating a new one --> | ||
|
|
||
| <!--- Change the title to summarise simply and succintly. --> | ||
|
|
||
| <!--- !!! Come talk to us on our Discord! https://discord.gg/xCa23pwJWY !!! --> | ||
|
|
||
| ## Problem | ||
|
|
||
| <!--- Why should we add this feature? How would it help spotDL users? --> | ||
|
|
||
| ## Solution | ||
|
|
||
| <!--- Describe a solution or implementation, if you have one. --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,38 @@ | ||
| # Title | ||
| <!--- Provide a general summary of your changes in the Title above --> | ||
|
|
||
| ## Description | ||
| <!--- Describe your changes in detail --> | ||
|
|
||
| ## Related Issue | ||
| <!--- This project only accepts pull requests related to open issues --> | ||
| <!--- If suggesting a new feature or change, please discuss it in an issue first --> | ||
| <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> | ||
| <!--- Please link to the issue here: --> | ||
|
|
||
| ## Motivation and Context | ||
| <!--- Why is this change required? What problem does it solve? --> | ||
|
|
||
| ## How Has This Been Tested? | ||
| <!--- Please describe in detail how you tested your changes. --> | ||
| <!--- Include details of your testing environment, and the tests you ran to --> | ||
| <!--- see how your change affects other areas of the code, etc. --> | ||
|
|
||
| ## Screenshots (if appropriate) | ||
|
|
||
| ## Types of Changes | ||
| <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> | ||
| - [ ] Bug fix (non-breaking change which fixes an issue) | ||
| - [ ] New feature (non-breaking change which adds functionality) | ||
| - [ ] Breaking change (fix or feature that would cause existing functionality to change) | ||
|
|
||
| ## Checklist | ||
| <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> | ||
| <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> | ||
| - [ ] My code follows the code style of this project | ||
| - [ ] My change requires a change to the documentation | ||
| - [ ] I have updated the documentation accordingly | ||
| - [ ] I have read the [CONTRIBUTING](/docs/CONTRIBUTING.md) document | ||
| - [ ] I have read the [CORE VALUES](/docs/CORE_VALUES.md) document | ||
| - [ ] I have added tests to cover my changes | ||
| - [ ] All new and existing tests passed | ||
| # Title | ||
| <!--- Provide a general summary of your changes in the Title above --> | ||
|
|
||
| ## Description | ||
| <!--- Describe your changes in detail --> | ||
|
|
||
| ## Related Issue | ||
| <!--- This project only accepts pull requests related to open issues --> | ||
| <!--- If suggesting a new feature or change, please discuss it in an issue first --> | ||
| <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> | ||
| <!--- Please link to the issue here: --> | ||
|
|
||
| ## Motivation and Context | ||
| <!--- Why is this change required? What problem does it solve? --> | ||
|
|
||
| ## How Has This Been Tested? | ||
| <!--- Please describe in detail how you tested your changes. --> | ||
| <!--- Include details of your testing environment, and the tests you ran to --> | ||
| <!--- see how your change affects other areas of the code, etc. --> | ||
|
|
||
| ## Screenshots (if appropriate) | ||
|
|
||
| ## Types of Changes | ||
| <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> | ||
| - [ ] Bug fix (non-breaking change which fixes an issue) | ||
| - [ ] New feature (non-breaking change which adds functionality) | ||
| - [ ] Breaking change (fix or feature that would cause existing functionality to change) | ||
|
|
||
| ## Checklist | ||
| <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> | ||
| <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> | ||
| - [ ] My code follows the code style of this project | ||
| - [ ] My change requires a change to the documentation | ||
| - [ ] I have updated the documentation accordingly | ||
| - [ ] I have read the [CONTRIBUTING](/docs/CONTRIBUTING.md) document | ||
| - [ ] I have read the [CORE VALUES](/docs/CORE_VALUES.md) document | ||
| - [ ] I have added tests to cover my changes | ||
| - [ ] All new and existing tests passed |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.