Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notice regarding the official singing keys #984

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add notice regarding the official singing keys #984

wants to merge 1 commit into from

Conversation

leonard84
Copy link
Member

@leonard84 leonard84 commented Apr 3, 2019 •
edited
Loading

This change is Reviewable

@leonard84 leonard84 requested a review from marcphilipp April 3, 2019 19:55
@codecov
Copy link

codecov bot commented Apr 3, 2019 •
edited
Loading

Codecov Report

Merging #984 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #984   +/-   ##
=========================================
  Coverage     75.99%   75.99%           
  Complexity     3544     3544           
=========================================
  Files           377      377           
  Lines         10788    10788           
  Branches       1374     1374           
=========================================
  Hits           8198     8198           
  Misses         2109     2109           
  Partials        481      481

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d751a0a...90c2557. Read the comment docs.

szpak
szpak requested changes Apr 3, 2019
View reviewed changes
Copy link
Member

@szpak szpak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have those keys added in a commit signed itself with the key which is somehow (https://keybase.io/ ? personal meeting at some conference?) associated with you @leonard84 .

@szpak szpak mentioned this pull request Apr 9, 2019
Open
szpak
szpak approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@szpak szpak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In most of the cases it's better to have it documented in that form than not at all. I created #989 to verify them somehow. Please merge as you wish.

@szpak szpak added this to the 2.0 milestone Feb 4, 2020
@leonard84 leonard84 removed this from the 2.0 milestone Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcphilipp marcphilipp marcphilipp approved these changes

@szpak szpak szpak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leonard84 @szpak @marcphilipp