Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fossa scan #546

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Fossa scan #546

merged 3 commits into from
Oct 5, 2023

Conversation

ashah-splunk
Copy link
Contributor

  • added FOSSA scan as part of CI testing

@ashah-splunk ashah-splunk requested a review from l00py September 26, 2023 06:04
l00py
l00py approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@l00py l00py left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  1. six.py will be removed in a future release
  2. Verified six 1.14.0 in Fossa: ✅
  3. Future action item: for 3rd party library, must use requirements.txt and setup.py and include at build time.
  4. Fossa scan requirements: https://docs.fossa.com/docs/python

@ashah-splunk ashah-splunk merged commit c5ce1a6 into master Oct 5, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l00py l00py l00py approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashah-splunk @l00py