Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Support for Python2 #456

Merged
merged 70 commits into from
Mar 15, 2024
Merged
Show file tree
Hide file tree
Changes from 55 commits
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
72d5fe1
removing python 2.7 from CI and local testing
ashah-splunk May 6, 2022
e3a09e7
code changes based on Pylint and 2to3 tool suggestions
ashah-splunk May 6, 2022
6429ae4
refractoring
ashah-splunk May 6, 2022
4cb0f4a
code changes
ashah-splunk May 6, 2022
aeae735
reverting f string change
ashah-splunk May 6, 2022
b0ca411
adding python 3.9 to CI
ashah-splunk May 9, 2022
5c90746
Merge branch 'py3-code-migration' into py3-testcases-refractor
ashah-splunk May 9, 2022
9329894
removed support for python2 from modularinput
akaila-splunk May 11, 2022
308873b
Merge branch 'py3-code-migration' into py3-modularinput-refactor
akaila-splunk May 11, 2022
83ecdf4
Update __init__.py
vmalaviya-splunk May 11, 2022
fe37aeb
Update binding.py
vmalaviya-splunk May 11, 2022
3231549
Update client.py
vmalaviya-splunk May 11, 2022
66dc351
Update data.py
vmalaviya-splunk May 11, 2022
a808a03
Update results.py
vmalaviya-splunk May 11, 2022
7e63b6a
Delete six.py
vmalaviya-splunk May 11, 2022
739a94a
Merge pull request #453 from splunk/py3-modularinput-refactor
ashah-splunk May 11, 2022
64de6a4
Merge pull request #454 from splunk/py3-testcases-refractor
ashah-splunk May 11, 2022
f68d408
Merge pull request #455 from splunk/py2to3-core
ashah-splunk May 11, 2022
4735248
Update argument.py
ashah-splunk May 11, 2022
464e75d
Merge branch 'py3-code-migration' of https://github.com/splunk/splunk…
ashah-splunk May 11, 2022
a066e7c
python 3.9
ashah-splunk May 11, 2022
5340cfc
Update tox.ini
ashah-splunk May 11, 2022
893b0d7
changes
ashah-splunk May 11, 2022
ec6907a
test changes for six.py removal
ashah-splunk May 11, 2022
9ffee31
refractor changes
ashah-splunk May 12, 2022
9df86a2
Merge branch 'develop' into py3-code-migration
ashah-splunk May 12, 2022
2c207d9
Update binding.py
ashah-splunk May 16, 2022
0250984
Update results.py
ashah-splunk May 16, 2022
b8d5b9c
Update client.py
ashah-splunk May 16, 2022
ea0b34b
refactoring
ashah-splunk May 17, 2022
079df7b
2to3 code refactoring
ashah-splunk May 17, 2022
3af370d
test case fix
ashah-splunk May 17, 2022
3a26633
sonar changes
ashah-splunk May 17, 2022
924a0eb
adding else after raise
ashah-splunk May 17, 2022
ed117bc
2to3 suggested changes
ashah-splunk May 17, 2022
468c92a
Update Makefile
ashah-splunk May 25, 2022
c772272
refractor changes
akaila-splunk Jun 3, 2022
78d9610
Merge branch 'develop' into py3-code-migration
ashah-splunk Jun 17, 2022
ff3f814
Update test.yml
ashah-splunk Oct 12, 2022
5094e0e
Update test.yml
ashah-splunk Oct 12, 2022
f1080cf
Merge branch 'develop' into py3-code-migration
akaila-splunk Oct 13, 2022
917cf04
updated binding.py
akaila-splunk Oct 13, 2022
8cc4c21
updated comments examples
akaila-splunk Nov 4, 2022
fc9b7c0
Merge branch 'develop' into py3-code-migration
ashah-splunk Dec 2, 2022
bf40010
added access to finished flag within metadata
ashah-splunk Dec 20, 2022
72372f9
Update internals.py
ashah-splunk Dec 20, 2022
14cdb92
Update test_search_command.py
ashah-splunk Dec 21, 2022
8c90d1e
refactoring
ashah-splunk Jan 17, 2023
fbcdd82
Merge branch 'develop' into py3-code-migration
ashah-splunk Feb 21, 2023
0766ed8
Update client.py
ashah-splunk Feb 22, 2023
b003be2
update string formatting
akaila-splunk Mar 3, 2023
3354403
Update test.yml
ashah-splunk Mar 9, 2023
d18b735
Copyright year updates
ashah-splunk Mar 9, 2023
d091844
Merge branch 'develop' into py3-code-migration
ashah-splunk Aug 7, 2023
2ee5000
matrix update
ashah-splunk Aug 7, 2023
21323ea
moved utility/helper functions to utils.py file
akaila-splunk Aug 21, 2023
d8d7da4
updates
ashah-splunk Sep 8, 2023
f40d2e8
Merge branch 'py3-code-migration' of https://github.com/splunk/splunk…
ashah-splunk Sep 8, 2023
54a6926
added check for user role
akaila-splunk Nov 8, 2023
0738778
Removed __test__ flags
ashah-splunk Feb 5, 2024
a8ede1a
Updates as per the review/feedback comments
ashah-splunk Feb 7, 2024
bad9127
Copyright year updates
ashah-splunk Feb 17, 2024
621232a
Remove conversion of iterables into list objects
maszyk99 Mar 4, 2024
6082881
Remove pass statement
maszyk99 Mar 4, 2024
9053482
Remove unneeded string format usage
maszyk99 Mar 4, 2024
1d1cc20
Pass correct args to logger
maszyk99 Mar 7, 2024
d805a7a
updated code
ashah-splunk Mar 13, 2024
e23fa4d
Update internals.py
ashah-splunk Mar 13, 2024
a633d6f
Add comment about json encoder back
maszyk99 Mar 13, 2024
85807ef
reverted line separators
ashah-splunk Mar 15, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
matrix:
os:
- ubuntu-latest
python: [3.7]
python: [ 3.7, 3.9]
splunk-version:
- "8.1"
- "8.2"
Expand Down
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
# Splunk Enterprise SDK for Python Changelog

## Version 2.0.0-beta

### Feature updates
* `ensure_binary`, `ensure_str`, `ensure_text` and `assert_regex` utility methods have been migrated from `six.py` to `splunklib/__init__.py`

### Major changes
* Removed Code specific to Python2
* Removed six.py dependency
* Removed `__future__` imports
* Refactored & Updated `splunklib` and `tests` to utilise Python3 features
* Updated CI test matrix to run with Python versions - 3.7, 3.9 and 3.10.7
ashah-splunk marked this conversation as resolved.
Show resolved Hide resolved
* Refactored Code throwing `deprecation` warnings
ashah-splunk marked this conversation as resolved.
Show resolved Hide resolved
* Refactored Code violating Pylint rules
## Version 1.7.4

### Bug fixes
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ docs:
.PHONY: test
test:
@echo "$(ATTN_COLOR)==> test $(NO_COLOR)"
@tox -e py27,py37
@tox -e py37,py39
ashah-splunk marked this conversation as resolved.
Show resolved Hide resolved

.PHONY: test_specific
test_specific:
Expand Down
7 changes: 2 additions & 5 deletions setup.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env python
#
# Copyright 2011-2015 Splunk, Inc.
# Copyright © 2011-2023 Splunk, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License"): you may
# not use this file except in compliance with the License. You may obtain
Expand All @@ -24,10 +24,7 @@
failed = False

def run_test_suite():
try:
import unittest2 as unittest
except ImportError:
import unittest
import unittest

def mark_failed():
global failed
Expand Down
2 changes: 1 addition & 1 deletion sitecustomize.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env python
#
# Copyright 2011-2015 Splunk, Inc.
# Copyright © 2011-2023 Splunk, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License"): you may
# not use this file except in compliance with the License. You may obtain
Expand Down
53 changes: 48 additions & 5 deletions splunklib/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2011-2015 Splunk, Inc.
# Copyright © 2011-2023 Splunk, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License"): you may
# not use this file except in compliance with the License. You may obtain
Expand All @@ -14,12 +14,10 @@

"""Python library for Splunk."""

from __future__ import absolute_import
from splunklib.six.moves import map
import logging

DEFAULT_LOG_FORMAT = '%(asctime)s, Level=%(levelname)s, Pid=%(process)s, Logger=%(name)s, File=%(filename)s, ' \
'Line=%(lineno)s, %(message)s'
'Line=%(lineno)s, %(message)s'
DEFAULT_DATE_FORMAT = '%Y-%m-%d %H:%M:%S %Z'


Expand All @@ -31,5 +29,50 @@ def setup_logging(level, log_format=DEFAULT_LOG_FORMAT, date_format=DEFAULT_DATE
format=log_format,
datefmt=date_format)

__version_info__ = (1, 7, 4)

def ensure_binary(s, encoding='utf-8', errors='strict'):
ashah-splunk marked this conversation as resolved.
Show resolved Hide resolved
"""
- `str` -> encoded to `bytes`
- `bytes` -> `bytes`
"""
if isinstance(s, str):
return s.encode(encoding, errors)

if isinstance(s, bytes):
return s

raise TypeError(f"not expecting type '{type(s)}'")


def ensure_str(s, encoding='utf-8', errors='strict'):
"""
- `str` -> `str`
- `bytes` -> decoded to `str`
"""
if isinstance(s, bytes):
return s.decode(encoding, errors)

if isinstance(s, str):
return s

raise TypeError(f"not expecting type '{type(s)}'")


def ensure_text(s, encoding='utf-8', errors='strict'):
"""
- `str` -> `str`
- `bytes` -> decoded to `str`
"""
if isinstance(s, bytes):
return s.decode(encoding, errors)
if isinstance(s, str):
return s
raise TypeError(f"not expecting type '{type(s)}'")


def assertRegex(self, *args, **kwargs):
return getattr(self, "assertRegex")(*args, **kwargs)


__version_info__ = (2, 0, 0)
__version__ = ".".join(map(str, __version_info__))
Loading