Adding more deployment endpoint code to Service #158
Conversation
vegitron
commented
Oct 28, 2016
vegitron
commented
- Fixes the URL for PATH_DEPLOYMENT_SERVERCLASSES
- Exposes deployment_apps, deployment_clients and server_classes in the Service class
- Adding virtualenv related entries to .gitignore
* Fixes the URL for PATH_DEPLOYMENT_SERVERCLASSES * Exposes deployment_apps, deployment_clients and server_classes in the Service class * Adding virtualenv related entries to .gitignore
|
Thanks for the PR @vegitron! |
|
Probably a 3. We can do a pip install from my github fork for a while if needed. Is the failing test something I should worry about? It doesn't look like it's related to my changes. |
|
@vegitron OK, we appreciate the flexibility. The test failure is a recent regression around SSL certs, it's unrelated to your changes |
There was a problem hiding this comment.
I'm not sure if you are still following this PR but if so this generally looks good - just a few small changes, resolving merge conflicts with the latest changes in develop and adding a tests to verify the functionality would allow us to merge this. Otherwise we can put this work on hold if someone else is able to pick it back up.
| class DeploymentApps(Collection): | ||
| """This class represents a collection of deployment apps.""" | ||
| def __init__(self, service): | ||
| Collection.__init__(self, service, PATH_DEPLOYMENT_APPS, item=ServerClass) |
There was a problem hiding this comment.
I think you meant item= DeploymentApp
| class DeploymentClient(Collection): | ||
| """This class represents a collection of deployment clients.""" | ||
| def __init__(self, service): | ||
| Collection.__init__(self, service, PATH_DEPLOYMENT_CLIENTS, item=ServerClass) |
There was a problem hiding this comment.
You'll want to change the name of the collection to DeploymentClients (plural) and this line to item=DeploymentClient
