Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change nonReapeater and add maxRepetitions as configurable #976

Draft
wants to merge 59 commits into
base: develop
Choose a base branch
from

Conversation

ajasnosz
Copy link
Collaborator

@ajasnosz ajasnosz commented Mar 8, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

manual tests, integration tests

Checklist

  • My commit message is conventional
  • I have run pre-commit on all files before creating the PR
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ajasnosz ajasnosz requested a review from wojtekzyla March 8, 2024 10:10
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.88%. Comparing base (cd2ddee) to head (ca65cfe).
Report is 37 commits behind head on develop.

Current head ca65cfe differs from pull request most recent head b70254c

Please upload reports for the commit b70254c to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #976   +/-   ##
========================================
  Coverage    84.87%   84.88%           
========================================
  Files           28       28           
  Lines         2017     2018    +1     
========================================
+ Hits          1712     1713    +1     
  Misses         305      305           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wojtekzyla and others added 3 commits March 14, 2024 12:33
feat: update ci-docker-deployment.yaml

feat: update ci-docker-deployment.yaml

feat: update ci-docker-deployment.yaml

fix: change ci-docker-deployment.yaml to work on branch push

feat: add asset upload to the CI

fix: run pre-commit

feat: add changelog update

feat: delete unnecessary images from documentation

feat: changes in documentation after review

feat: more updates after PR review

fix: rename variables in manage_secrets.py and fix typos in documentation

fix typo in documentation
# [1.11.0-beta.1](v1.10.0...v1.11.0-beta.1) (2024-03-14)

### Bug Fixes

* update .releaserc ([#979](#979)) ([2bcfedd](2bcfedd))

### Features

* add docker compose deployment configuration ([#973](#973)) ([461774a](461774a))
@ajasnosz ajasnosz force-pushed the feat/improve-polling-time branch from 81a8052 to 0ea068c Compare March 20, 2024 09:06
@ajasnosz ajasnosz changed the title feat: add nonReapeater and maxRepetitions to config feat: change nonReapeater and add maxRepetitions as configurable Mar 20, 2024
* chore(deps): update dependency pytest to v8.1.1

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: ajasnosz <[email protected]>
@ajasnosz ajasnosz force-pushed the feat/improve-polling-time branch 2 times, most recently from d0a5434 to ca65cfe Compare March 20, 2024 14:55
ajasnosz and others added 19 commits March 21, 2024 08:21
* chore: update jinja2 and pycryptodomex

* test: test [run-int-tests]
….2 (#980)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….4.2 (#982)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…958)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
# [1.11.0-beta.2](v1.11.0-beta.1...v1.11.0-beta.2) (2024-03-27)

### Bug Fixes

* fix formatting of Debug Splunk Connect for SNMP documentation ([#988](#988)) ([5a944e4](5a944e4))
* fix: improve error messages
fix: change line formatting

fix: add new line character at the end
# [1.11.0-beta.3](v1.11.0-beta.2...v1.11.0-beta.3) (2024-04-12)

### Bug Fixes

* improve mkdocs.yml file formatting ([#994](#994)) ([ead94b3](ead94b3))
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
wojtekzyla and others added 19 commits April 19, 2024 14:10
…ating to SC4SNMP-UI (#998)

fix: update wrong variable name

[run-ui-tests]

fix: update CHANGELOG

fix: update CHANGELOG
# [1.11.0-beta.4](v1.11.0-beta.3...v1.11.0-beta.4) (2024-04-19)

### Bug Fixes

* fix a bug with values.yaml not being loaded to the UI while migrating to SC4SNMP-UI ([#998](#998)) ([3c9273b](3c9273b))
# [1.11.0-beta.5](v1.11.0-beta.4...v1.11.0-beta.5) (2024-04-22)

### Bug Fixes

* fix sonarqube issues with f-string and regex ([#1001](#1001)) ([c415d0e](c415d0e))
# [1.11.0-beta.6](v1.11.0-beta.5...v1.11.0-beta.6) (2024-04-25)

### Bug Fixes

* update microk8s to v1.30 ([#1004](#1004)) ([642c539](642c539))
[run-ui-tests]

[run-int-tests]

chore: update function names in tests [run-int-tests]

[run-int-tests] [run-ui-tests]

chore: run pre-commit

chore: rename var_bind to varbind

chore: rename user_name to username, [run-ui-tests] [run-int-tests]
…hip of /.pysnmp and /tmp in Dockerfile. Explicitly mount read-only and read-write volumes in docker compose (#1007)
# [1.11.0-beta.7](v1.11.0-beta.6...v1.11.0-beta.7) (2024-05-23)

### Bug Fixes

* fix wring log message in UI tests and change sleep time in UI tests ([#1022](#1022)) ([3cd6e9e](3cd6e9e))
# [1.11.0-beta.8](v1.11.0-beta.7...v1.11.0-beta.8) (2024-05-27)

### Features

* add docker scaling ([#1024](#1024)) ([69d15e0](69d15e0))
@wojtekzyla wojtekzyla force-pushed the feat/improve-polling-time branch from ca65cfe to 26d089a Compare June 11, 2024 14:39
Base automatically changed from develop to main July 24, 2024 12:40
@ajasnosz ajasnosz changed the base branch from main to develop July 24, 2024 13:35
Base automatically changed from develop to main October 16, 2024 10:03
@ajasnosz ajasnosz changed the base branch from main to develop October 16, 2024 10:29
ajasnosz and others added 4 commits November 26, 2024 12:55
* # Conflicts:
#	.github/workflows/agreements.yaml
#	.github/workflows/cd-pages.yaml
#	.github/workflows/ci-main.yaml
#	.github/workflows/ci-release-pr.yaml
#	.github/workflows/ci-release.yaml
#	.github/workflows/release-notes.yaml
#	.gitignore
#	CHANGELOG.md
#	charts/splunk-connect-for-snmp/Chart.lock
#	charts/splunk-connect-for-snmp/Chart.yaml
#	charts/splunk-connect-for-snmp/templates/worker/_helpers.tpl
#	create_packages.sh
#	docker_compose/.env
#	docker_compose/Corefile
#	docker_compose/manage_secrets.py
#	docs/bestpractices.md
#	docs/dockercompose/2-download-package.md
#	docs/dockercompose/3-inventory-configuration.md
#	docs/dockercompose/4-scheduler-configuration.md
#	docs/dockercompose/5-traps-configuration.md
#	docs/dockercompose/6-env-file-configuration.md
#	docs/dockercompose/7-snmpv3-secrets.md
#	docs/gui/enable-gui.md
#	mkdocs.yml
#	poetry.lock
#	pyproject.toml
#	rendered/manifests/tests/splunk-connect-for-snmp/templates/worker/poller/deployment.yaml
#	rendered/manifests/tests/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests/splunk-connect-for-snmp/templates/worker/trap/deployment.yaml
#	rendered/manifests/tests_autoscaling_enabled/splunk-connect-for-snmp/templates/worker/poller/deployment.yaml
#	rendered/manifests/tests_autoscaling_enabled/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests_autoscaling_enabled/splunk-connect-for-snmp/templates/worker/trap/deployment.yaml
#	rendered/manifests/tests_autoscaling_enabled_deprecated/splunk-connect-for-snmp/templates/worker/poller/deployment.yaml
#	rendered/manifests/tests_autoscaling_enabled_deprecated/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests_autoscaling_enabled_deprecated/splunk-connect-for-snmp/templates/worker/trap/deployment.yaml
#	rendered/manifests/tests_enable_ui/splunk-connect-for-snmp/templates/worker/poller/deployment.yaml
#	rendered/manifests/tests_enable_ui/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests_enable_ui/splunk-connect-for-snmp/templates/worker/trap/deployment.yaml
#	rendered/manifests/tests_only_polling/splunk-connect-for-snmp/templates/worker/poller/deployment.yaml
#	rendered/manifests/tests_only_polling/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests_only_traps/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests_only_traps/splunk-connect-for-snmp/templates/worker/trap/deployment.yaml
#	rendered/manifests/tests_probes_enabled/splunk-connect-for-snmp/templates/worker/poller/deployment.yaml
#	rendered/manifests/tests_probes_enabled/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests_probes_enabled/splunk-connect-for-snmp/templates/worker/trap/deployment.yaml
#	splunk_connect_for_snmp/__init__.py
#	splunk_connect_for_snmp/enrich/tasks.py
#	splunk_connect_for_snmp/inventory/loader.py
#	splunk_connect_for_snmp/snmp/auth.py
#	splunk_connect_for_snmp/snmp/manager.py
#	splunk_connect_for_snmp/splunk/tasks.py
#	splunk_connect_for_snmp/traps.py
#	test/snmp/test_auth.py

* chore: update lock

* test: test [run-int-tests]
#	docs/bestpractices.md
#	docs/gui/enable-gui.md
#	docs/microk8s/configuration/poller-configuration.md
#	rendered/manifests/tests/splunk-connect-for-snmp/templates/worker/poller/deployment.yaml
#	rendered/manifests/tests/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests/splunk-connect-for-snmp/templates/worker/trap/deployment.yaml
#	rendered/manifests/tests_autoscaling_enabled/splunk-connect-for-snmp/templates/worker/poller/deployment.yaml
#	rendered/manifests/tests_autoscaling_enabled/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests_autoscaling_enabled/splunk-connect-for-snmp/templates/worker/trap/deployment.yaml
#	rendered/manifests/tests_autoscaling_enabled_deprecated/splunk-connect-for-snmp/templates/worker/poller/deployment.yaml
#	rendered/manifests/tests_autoscaling_enabled_deprecated/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests_autoscaling_enabled_deprecated/splunk-connect-for-snmp/templates/worker/trap/deployment.yaml
#	rendered/manifests/tests_enable_ui/splunk-connect-for-snmp/templates/worker/poller/deployment.yaml
#	rendered/manifests/tests_enable_ui/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests_enable_ui/splunk-connect-for-snmp/templates/worker/trap/deployment.yaml
#	rendered/manifests/tests_only_polling/splunk-connect-for-snmp/templates/worker/poller/deployment.yaml
#	rendered/manifests/tests_only_polling/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests_only_traps/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests_only_traps/splunk-connect-for-snmp/templates/worker/trap/deployment.yaml
#	rendered/manifests/tests_probes_enabled/splunk-connect-for-snmp/templates/worker/poller/deployment.yaml
#	rendered/manifests/tests_probes_enabled/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests_probes_enabled/splunk-connect-for-snmp/templates/worker/trap/deployment.yaml
#	splunk_connect_for_snmp/snmp/manager.py
# Conflicts:
#	docs/gui/enable-gui.md
#	docs/microk8s/configuration/poller-configuration.md
#	rendered/manifests/tests/splunk-connect-for-snmp/templates/worker/poller/deployment.yaml
#	rendered/manifests/tests/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests/splunk-connect-for-snmp/templates/worker/trap/deployment.yaml
#	rendered/manifests/tests_autoscaling_enabled/splunk-connect-for-snmp/templates/worker/poller/deployment.yaml
#	rendered/manifests/tests_autoscaling_enabled/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests_autoscaling_enabled/splunk-connect-for-snmp/templates/worker/trap/deployment.yaml
#	rendered/manifests/tests_autoscaling_enabled_deprecated/splunk-connect-for-snmp/templates/worker/poller/deployment.yaml
#	rendered/manifests/tests_autoscaling_enabled_deprecated/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests_autoscaling_enabled_deprecated/splunk-connect-for-snmp/templates/worker/trap/deployment.yaml
#	rendered/manifests/tests_enable_ui/splunk-connect-for-snmp/templates/worker/poller/deployment.yaml
#	rendered/manifests/tests_enable_ui/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests_enable_ui/splunk-connect-for-snmp/templates/worker/trap/deployment.yaml
#	rendered/manifests/tests_only_polling/splunk-connect-for-snmp/templates/worker/poller/deployment.yaml
#	rendered/manifests/tests_only_polling/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests_only_traps/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests_only_traps/splunk-connect-for-snmp/templates/worker/trap/deployment.yaml
#	rendered/manifests/tests_probes_enabled/splunk-connect-for-snmp/templates/worker/poller/deployment.yaml
#	rendered/manifests/tests_probes_enabled/splunk-connect-for-snmp/templates/worker/sender/deployment.yaml
#	rendered/manifests/tests_probes_enabled/splunk-connect-for-snmp/templates/worker/trap/deployment.yaml
#	splunk_connect_for_snmp/snmp/manager.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants