forked from open-telemetry/opentelemetry-demo
-
Notifications
You must be signed in to change notification settings - Fork 3
Add Splunk RUM custom workflow events for cart operations #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Services: payment Updated: - Source k8s manifests with new image references Note: .service-versions.yaml updated locally but not committed
Generated test manifest for Astronomy Shop - Base Version: 1.0.1 (unchanged) - Test Version: demo-for-rob-1 - Manifest: kubernetes/TEST-splunk-astronomy-shop-demo-for-rob-1.yaml - Generated by: GitHub Actions (test build) Note: SPLUNK-VERSION file was NOT modified.
Automatically removed by remove-test-manifests workflow
Resolved image version conflicts by accepting upstream 1.4.0 versions
Added ability to specify a custom version when building a single service: - New 'custom' option in version_bump dropdown - New 'custom_version' text input for specifying exact version - Validation ensures custom only works with single service (not 'all') - Custom builds don't modify SPLUNK-VERSION (single service only) - Clear PR title showing service and custom version Also updated flagd-config to set paymentServiceUnreachable default to 50%
Guard against rendering/fetching product images before data is loaded, preventing requests to /images/products/undefined through frontend-proxy.
- Add useRef to ensure error only fires once per browser session - Update error message to simulate pricing race condition - Add detailed comments explaining the demo scenario - Add error.synthetic attribute for filtering in Splunk
Services: frontend Updated: - Source k8s manifests with new image references Note: .service-versions.yaml updated locally but not committed
Use actual function calls instead of new Error() to generate a real stack trace that sourcemaps can map back to original source code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
AddToCartandPlaceOrderworkflow spans with attributesCartPageErrordemo that fires once per session to demonstrate JS error tracking in Splunk RUMpictureto prevent 404 requests to/images/products/undefinedTest plan
/images/products/undefinedin frontend-proxy logs