Potential fix for watcher failing to collect events after about an hour

[peter-moffatt]

This is a potential solution for issue #9 which I am also experiencing. I have tested it in a Kubernetes cluster and I was able to successfully watch events for over 2 hours.

The fix is based on advice in ManageIQ/kubeclient#273.

This change breaks two of the unit tests which will need to be resolved before this is merged. I've never done any Ruby before so it'll take me a bit of time to figure out how to fix them. I will therefore delay figuring out how to fix the tests until I've got feedback that this is the right approach to fixing the problem.

[dtregonning]

Thanks @peter-moffatt - thanks for providing the link to the discussion and a potential fix. Its something that we've heard quite a few times. We have done some testing and this looks promising. Will update soon with results.

[peter-moffatt]

Thanks for the update. I've had it watching events continuously for the last 4 days with no problems noticed so far.

[dtregonning]

@peter-moffatt - we are doing an update release to this project now with the plan to merge changes in after. Just a heads up the new project release wont have the fix.

[max-rocket-internet]

@dtregonning any update on this?

[mohitevishal]

Any update? Are you folks going to pull this patch? @dtregonning ?

[dtregonning]

Hey @mohitevishal, @max-rocket-internet - yup. Team talked about it today. We will include this in a maintenance release and bump.

[max-rocket-internet]

@peter-moffatt could you rebase? And then perhaps we can merge?

[peter-moffatt]

@peter-moffatt could you rebase? And then perhaps we can merge?

Done.

[max-rocket-internet]

Another conflict @peter-moffatt 😞

@peter-moffatt any update?

[dtregonning]

@max-rocket-internet @peter-moffatt - thank you so much for your efforts on this. We modified your original submitted fix and had it merged into develop to get it running in our testing environments. WE had concerns with the thread creates within the loop. Im going to bump up the version of Objects to 1.1.1 with the fix included and release. Ill leave this open for now in case we hit any other issues.
#21

[max-rocket-internet]

Thanks!

[peter-moffatt]

Thanks @dtregonning.

[max-rocket-internet]

How do we get this version from rubygems?

[dtregonning]

Fixed in #27