Skip to content

Commit

Permalink
chore(appinspect-api): make it pass (#1491)
Browse files Browse the repository at this point in the history
**Issue number:** N/A

### PR Type

**What kind of change does this PR introduce?**
* [ ] Feature
* [ ] Bug Fix
* [ ] Refactoring (no functional or API changes)
* [ ] Documentation Update
* [x] Maintenance (dependency updates, CI, etc.)

## Summary

### Changes

* Updating license path in "everything" add-on to pass AppInspect API
check.
* Removed `check_for_compiled_python` known issue from ignore file.
* Run `appinspect-api` for every PR.

### User experience

N/A

## Checklist

If an item doesn't apply to your changes, leave it unchecked.

* [x] I have performed a self-review of this change according to the
[development
guidelines](https://splunk.github.io/addonfactory-ucc-generator/contributing/#development-guidelines)
* [ ] Tests have been added/modified to cover the changes [(testing
doc)](https://splunk.github.io/addonfactory-ucc-generator/contributing/#build-and-test)
* [ ] Changes are documented
* [x] PR title and description follows the [contributing
principles](https://splunk.github.io/addonfactory-ucc-generator/contributing/#pull-requests)
  • Loading branch information
artemrys authored Nov 27, 2024
1 parent e1fe2b0 commit e8d03bb
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/build-test-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -325,8 +325,7 @@ jobs:
needs: build-test-addon
if: |
!cancelled() &&
needs.build-test-addon.result == 'success' &&
( github.base_ref == 'main' || github.ref_name == 'main' )
needs.build-test-addon.result == 'success'
runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand Down
Original file line number Diff line number Diff line change
@@ -1,2 +0,0 @@
check_for_compiled_python:
comment: 'Expected failure as compiled python file was detected in your build.'
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"commonInformationModels": null,
"license": {
"name": null,
"text": "LICENSES/Apache-2.0.txt",
"text": "LICENSES/Apache License 2.0.txt",
"uri": null
},
"privacyPolicy": {
Expand Down

0 comments on commit e8d03bb

Please sign in to comment.