Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: support Windows when checking library version (#1482)
**Issue number:[ADDON-76665](https://splunk.atlassian.net/browse/ADDON-76665)** ### PR Type **What kind of change does this PR introduce?** * [ ] Feature * [x] Bug Fix * [ ] Refactoring (no functional or API changes) * [ ] Documentation Update * [ ] Maintenance (dependency updates, CI, etc.) ## Summary We were missing a command to fetch data from stdout (`pip show --version {lib}`) for windows. For unix we use "grep" and for windows "findstr". ### Changes Changed logic of `_pip_is_lib_installed` to also check library version using "findstr" if "grep" returns non 0 status. ### User experience Fixed an issue where Windows users were unable to build an add-on because of the error `SplunktaucclibNotFound` ## Checklist If an item doesn't apply to your changes, leave it unchecked. * [x] I have performed a self-review of this change according to the [development guidelines](https://splunk.github.io/addonfactory-ucc-generator/contributing/#development-guidelines) * [x] Tests have been added/modified to cover the changes [(testing doc)](https://splunk.github.io/addonfactory-ucc-generator/contributing/#build-and-test) * [ ] Changes are documented * [x] PR title and description follows the [contributing principles](https://splunk.github.io/addonfactory-ucc-generator/contributing/#pull-requests) --------- Co-authored-by: Artem Rys <[email protected]> Co-authored-by: srv-rr-github-token <[email protected]> Co-authored-by: soleksy-splunk <[email protected]> Co-authored-by: Viktor Tsvetkov <[email protected]>
- Loading branch information