Skip to content

Commit

Permalink
fix: allow packaging from 23.0 (#1484)
Browse files Browse the repository at this point in the history
**Issue number:** N/A

### PR Type

**What kind of change does this PR introduce?**
* [ ] Feature
* [x] Bug Fix
* [ ] Refactoring (no functional or API changes)
* [ ] Documentation Update
* [ ] Maintenance (dependency updates, CI, etc.)

## Summary

### Changes

Allow `packaging` from a version "23.0".

To reproduce the issue run

```bash
pip install splunk-add-on-ucc-framework==5.53.1
pip install splunk-appinspect==3.8.1
```

You should see

```
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
splunk-add-on-ucc-framework 5.53.1 requires packaging==24.0, but you have packaging 23.0 which is incompatible.
```

in your console.

### User experience

Developers can install latest version of both UCC and Splunk AppInspect
CLI in the same virtual environment.

## Checklist

If an item doesn't apply to your changes, leave it unchecked.

* [x] I have performed a self-review of this change according to the
[development
guidelines](https://splunk.github.io/addonfactory-ucc-generator/contributing/#development-guidelines)
* [ ] Tests have been added/modified to cover the changes [(testing
doc)](https://splunk.github.io/addonfactory-ucc-generator/contributing/#build-and-test)
* [ ] Changes are documented
* [x] PR title and description follows the [contributing
principles](https://splunk.github.io/addonfactory-ucc-generator/contributing/#pull-requests)
  • Loading branch information
artemrys authored Nov 26, 2024
1 parent 282e2ef commit 29accc4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jsonschema = "^4.4.0"
PyYAML = "^6.0"
defusedxml = "^0.7.1"
colorama = "^0.4.6"
packaging = "24.0"
packaging = ">=23.0"

[tool.poetry.group.dev.dependencies]
mkdocs = "^1.4.2"
Expand Down

0 comments on commit 29accc4

Please sign in to comment.