test(SingleInputComponent): add expect and fix warning (#1467)

splunk · Nov 20, 2024 · 180c28d · 180c28d
1 parent 2574451
commit 180c28d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/ui/.eslintrc.js b/ui/.eslintrc.js
@@ -26,6 +26,7 @@ module.exports = {
         // https://typescript-eslint.io/rules/no-use-before-define/#how-to-use
         'no-use-before-define': 'off',
         '@typescript-eslint/no-use-before-define': ['error', { variables: false }],
+        'jest/expect-expect': 'error',
     },
     root: true,
 };
diff --git a/ui/src/components/SingleInputComponent/SingleInputComponent.test.tsx b/ui/src/components/SingleInputComponent/SingleInputComponent.test.tsx
@@ -207,7 +207,9 @@ it('should fetch options from API when endpointUrl is provided', async () => {
         />
     );
     await userEvent.click(screen.getByRole('combobox'));
-    await screen.findByRole('option', { name: firstEntry.content.testLabel });
+    expect(
+        await screen.findByRole('option', { name: firstEntry.content.testLabel })
+    ).toBeInTheDocument();
 
     const secondEntry = mockedEntries[1];
     rerender(
@@ -217,17 +219,23 @@ it('should fetch options from API when endpointUrl is provided', async () => {
         />
     );
     await userEvent.click(screen.getByRole('combobox'));
-    await screen.findByRole('option', { name: secondEntry.content.testLabel });
+    expect(
+        await screen.findByRole('option', { name: secondEntry.content.testLabel })
+    ).toBeInTheDocument();
 
     const thirdEntry = mockedEntries[2];
     rerender(
         <SingleInputComponent {...baseProps} dependencyValues={{ name: true, region: false }} />
     );
     await userEvent.click(screen.getByRole('combobox'));
-    await screen.findByRole('option', { name: thirdEntry.content.testLabel });
+    expect(
+        await screen.findByRole('option', { name: thirdEntry.content.testLabel })
+    ).toBeInTheDocument();
 
     const fourthEntry = mockedEntries[3];
     rerender(<SingleInputComponent {...baseProps} dependencyValues={{ name: 0, region: 0 }} />);
     await userEvent.click(screen.getByRole('combobox'));
-    await screen.findByRole('option', { name: fourthEntry.content.testLabel });
+    expect(
+        await screen.findByRole('option', { name: fourthEntry.content.testLabel })
+    ).toBeInTheDocument();
 });