Skip to content

Commit

Permalink
chore(smartx): update to 5.3.1 (#1481)
Browse files Browse the repository at this point in the history
**Issue number:** N/A

### PR Type

**What kind of change does this PR introduce?**
* [ ] Feature
* [ ] Bug Fix
* [ ] Refactoring (no functional or API changes)
* [ ] Documentation Update
* [x] Maintenance (dependency updates, CI, etc.)

## Summary

### Changes

Updating SmartX to 5.3.1
(https://github.com/splunk/addon-factory-smartx-ui-test-library/releases/tag/v5.3.1).

To fix
https://github.com/splunk/addonfactory-ucc-generator/actions/runs/12010223758/job/33477076244?pr=1475#annotation:8:123.

2 UI tests were adjusted not to open Splunk's documentation website but
only to check that the `href` element is a correct one. This should
actually fix the error mentioned above.

### User experience

N/A

## Checklist

If an item doesn't apply to your changes, leave it unchecked.

* [x] I have performed a self-review of this change according to the
[development
guidelines](https://splunk.github.io/addonfactory-ucc-generator/contributing/#development-guidelines)
* [x] Tests have been added/modified to cover the changes [(testing
doc)](https://splunk.github.io/addonfactory-ucc-generator/contributing/#build-and-test)
* [ ] Changes are documented
* [x] PR title and description follows the [contributing
principles](https://splunk.github.io/addonfactory-ucc-generator/contributing/#pull-requests)
  • Loading branch information
artemrys authored Nov 25, 2024
1 parent 2b34c6b commit 0013b66
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 11 deletions.
8 changes: 4 additions & 4 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ mkdocs = "^1.4.2"
importlib-metadata = {version="*", python="<3.8"}
pytest = "^7.2.1"
pytest-splunk-addon = "^5.4.0"
pytest-splunk-addon-ui-smartx = "^5.3.0"
pytest-splunk-addon-ui-smartx = "^5.3.1"
pytest-rerunfailures = "^11.1.1"
mkdocs-material = "^9.1.3"
mkdocstrings = {version=">=0", extras=["python"]}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1906,10 +1906,10 @@
"meta": {
"name": "Splunk_TA_UCCExample",
"restRoot": "splunk_ta_uccexample",
"version": "5.52.0+70c7e9d6b",
"version": "5.53.2+ed749a5ec",
"displayName": "Splunk UCC test Add-on",
"schemaVersion": "0.0.9",
"_uccVersion": "5.52.0",
"_uccVersion": "5.53.2",
"supportedThemes": [
"light",
"dark"
Expand Down
7 changes: 5 additions & 2 deletions tests/ui/test_configuration_page_account_tab.py
Original file line number Diff line number Diff line change
Expand Up @@ -1033,8 +1033,11 @@ def test_account_helplink(self, ucc_smartx_selenium_helper, ucc_smartx_rest_help
account = AccountPage(ucc_smartx_selenium_helper, ucc_smartx_rest_helper)
go_to_link = "https://docs.splunk.com/Documentation"
account.entity.open()
with account.entity.help_link.open_link():
self.assert_util(account.entity.help_link.get_current_url, go_to_link)

assert (
account.entity.help_link.internal_container.get_attribute("href")
== go_to_link
)

@pytest.mark.execute_enterprise_cloud_true
@pytest.mark.forwarder
Expand Down
7 changes: 5 additions & 2 deletions tests/ui/test_input_page.py
Original file line number Diff line number Diff line change
Expand Up @@ -1037,8 +1037,11 @@ def test_example_input_one_help_link(
go_to_link = "https://docs.splunk.com/Documentation"
input_page.create_new_input.select("Example Input One")
input_page.entity1.example_account.wait_for_values()
with input_page.entity1.help_link.open_link():
self.assert_util(input_page.entity1.help_link.get_current_url, go_to_link)

assert (
input_page.entity1.help_link.internal_container.get_attribute("href")
== go_to_link
)

@pytest.mark.execute_enterprise_cloud_true
@pytest.mark.forwarder
Expand Down

0 comments on commit 0013b66

Please sign in to comment.