Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toBoolean to allow false #91

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

Cipa
Copy link

@Cipa Cipa commented Apr 22, 2011

Fix to toBoolean - Allows the use property =false instead of property=0
Fix to support 'true' when passed as a string. For some reason 'true' came out as an empty string which is false

@Cipa Cipa closed this Apr 23, 2011
@Cipa Cipa reopened this Apr 23, 2011
@Cipa
Copy link
Author

Cipa commented Apr 23, 2011

Colorbox Plugin Support: http://colorpowered.com/colorbox/
http://modxrules.com/revo/demo/colorbox-gallery.html

Supported settings - in [] supported values

theme => theme1 [choose from theme1 to theme5]
transition => elastic [elastic,fade,none]
speed => 350
width => false
height => false
maxWidth => false
maxHeight => false
opacity => 0.85
loop => true
slideshow => false
slideshowSpeed => 2500
slideshowAuto => true
slideshowStart => 'start slideshow'
slideshowStop => 'stop slideshow'
current => 'image {current} of {total}'
previous => 'previous'
next => "next"
close => "close"
colorboxUseCss => true
colorboxUseJs => true

Example:

[[!Gallery?
&toPlaceholder=gallery
&album=Test
&plugin=colorbox
&theme=theme5
&transition=fade
&speed = 100
&opacity = 0.3
&slideshow = true
&loop = false
]]
[[+gallery]]

@Cipa Cipa closed this Apr 23, 2011
@Cipa Cipa reopened this Apr 23, 2011
@opengeek
Copy link
Collaborator

Cipa, is this still in any way a valid pull request for the original subject—"Fix toBoolean to allow false" ?

@jpdevries
Copy link
Collaborator

Thanks @Cipa. Got this in a testing branch over at modxcms/Gallery. Just want to make sure Colorbox isn't already outdated since this PR got so stale.

modxcms@9c9213a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants