refactor(retrofit2): upgrade all retrofit clients to retrofit2 #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
reviewed
Feb 11, 2025
gate-core/src/main/java/com/netflix/spinnaker/gate/services/TaskService.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 11, 2025
gate-web/src/test/groovy/com/netflix/spinnaker/gate/ApplicationServiceSpec.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 11, 2025
...c/test/groovy/com/netflix/spinnaker/gate/health/DownstreamServicesHealthIndicatorSpec.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 11, 2025
gate-web/src/test/groovy/com/netflix/spinnaker/gate/security/ldap/LdapAuthSpec.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 11, 2025
gate-web/src/test/java/com/netflix/spinnaker/gate/controllers/ArtifactControllerTest.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 11, 2025
gate-web/src/test/java/com/netflix/spinnaker/gate/controllers/ArtifactControllerTest.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 11, 2025
gate-web/src/test/java/com/netflix/spinnaker/gate/controllers/InvokePipelineConfigTest.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 11, 2025
gate-web/src/test/java/com/netflix/spinnaker/gate/controllers/InvokePipelineConfigTest.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 11, 2025
gate-web/src/test/java/com/netflix/spinnaker/gate/controllers/InvokePipelineConfigTest.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 11, 2025
gate-web/src/test/java/com/netflix/spinnaker/gate/controllers/InvokePipelineConfigTest.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 11, 2025
dbyron-sf
reviewed
Feb 11, 2025
kirangodishala
force-pushed
the
retrofit2-upgrade
branch
from
257cb88 to
0aafa16
Compare
kirangodishala
force-pushed
the
retrofit2-upgrade
branch
from
0aafa16 to
5a492b6
Compare
kirangodishala
force-pushed
the
retrofit2-upgrade
branch
from
5a492b6 to
114b145
Compare
dbyron-sf
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of retrofit 2.x client in place of retrofit 1.9 and make required changes accordingly.
All the retrofit1 dependencies and references are removed.