Extract dependency WITs during build#3378
Draft
itowlson wants to merge 5 commits intospinframework:mainfrom
Draft
Extract dependency WITs during build#3378itowlson wants to merge 5 commits intospinframework:mainfrom
itowlson wants to merge 5 commits intospinframework:mainfrom
Conversation
Collaborator
Author
|
I think I do determine the exported interfaces by looking at worlds, but I believe it's safe to ignore I am not sure if there is some edge case when a component exports interfaces from other packages but that seems like a potential issue regardless of |
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
b6ccf96 to
9df21d8
Compare
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3376.
WIP. Current status: 1.
contains gross, gross hacksreplaced with BEAUTIFUL AND ELEGANT hacks, and 2. incomplete.Work needed:
exportTest thatI think this works but a second tester would be very welcomeincludeis handled correctlyProvide a way to invoke it outside of build(can be deferred if naming is hard, which it always is)