Draft
Conversation
020f2a8 to
430093e
Compare
Collaborator
Author
|
Okay there is some silliness going on where it has upgraded an unrelated dependency that now requires Rust 1.83, but that makes one of the examples fling a strange new lint. I'll see if I can roll things back. Faugh. |
ee1a99d to
2630a65
Compare
lann
reviewed
Mar 25, 2025
lann
reviewed
Mar 25, 2025
crates/factor-blobstore/src/host.rs
Outdated
| } | ||
|
|
||
| pub struct BlobStoreDispatch<'a> { | ||
| allowed_containers: HashSet<String>, |
Collaborator
There was a problem hiding this comment.
I'm not entirely sure that it can be but if this can be borrowed it would save a clone
Suggested change
| allowed_containers: HashSet<String>, | |
| allowed_containers: &'a HashSet<String>, |
Collaborator
There was a problem hiding this comment.
Actually if this one works then probably all of the Arcs below could just be borrows. You'd still need the locks for interior mutability of course.
Collaborator
Author
There was a problem hiding this comment.
@lann I tried it and it hasn't segfaulted yet - thanks for the suggestion!
6045e54 to
74449eb
Compare
bc914b7 to
fa20d4f
Compare
fa20d4f to
61791be
Compare
61791be to
9243ca9
Compare
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
9243ca9 to
e4bfdde
Compare
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is lurching towards readiness, although it still needs a lot of tidying. E.g.
InstanceBuilder::build()doesn't actually produce a dispatcher object - instead the factor setup does some terrifying shenanigans to try to hook our streams up to Spin's WASI implementation, which means the dispatcher is produced at link time rather than build time.There are some underspecification issues in the current draft of wasi-blobstore: I think I've made my implementations at least consistent, but I probably need to go back over and check that too.
The implementations in this PR are:
I've tested all of them but not tested them hard.
Anyway, I'm sorry this is such a beast and I'm sorry it's still messy - I wanted to do enough to have reasonable confidence in the internal provider API, and I think I'm there bar the renaming and tidying, but it means there's a lot of code, and there's a lot of scar tissue!