update rust target to wasm32-wasip1#62
Merged
michelleN merged 1 commit intospinframework:mainfrom Mar 14, 2025
Merged
Conversation
Contributor
Author
|
Should we also update the docs/examples in this repo to reference |
Contributor
|
Yep. And also update the path in the source field of each component. |
Signed-off-by: Michelle Dhanani <michelle@fermyon.com>
fibonacci1729
approved these changes
Mar 13, 2025
Contributor
Author
|
CI failed just now with the following error which I was able to replicate locally but when I went to re-run the tests the test passed both locally and in CI. |
Contributor
|
@michelleN I can't see any reason why that would flake. Maybe run it a few more times and if it happens again we can look into it, and if not then write it off to cosmic rays? It's a bit worrying but if we can't make it happen again then eh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.