refactor(keyboardShortcut): cleanup & patch keybinds

[ohitstom]

This PR removes redundant keybinds that Spotify have implemented into their own shortcut menu (ctrl + ?), whilst also fixing pre-existing ones (namely rotate navbar item which broke from libx).

The registering of these binds has also been moved to a json/object structure making it easier to expand upon both on the dev side and in a future settings menu if we were to add one.

Also moved from Spicetify.Keyboard to Spicetify.Mousetrap

(docs will need rewriting)

[Delusoire]

It takes a noticeable amount of time (seconds) to add/remove hundreds of elements directly to/from the DOM. All element.remove() and element.append() should happen only after vimOverlay is removed, and when all the changes to its descendants are made, we then can add it back to the DOM. With this, the whole operation becomes quasi-instant.

[ohitstom]

It takes a noticeable amount of time (seconds) to add/remove hundreds of elements directly to/from the DOM. All element.remove() and element.append() should happen only after vimOverlay is removed, and when all the changes to its descendants are made, we then can add it back to the DOM. With this, the whole operation becomes quasi-instant.

i haven't modified this behavior nor do I plan to

[afonsojramos]

Looks good overall! Just want to check the missing shortcuts

[ohitstom]

It takes a noticeable amount of time (seconds) to add/remove hundreds of elements directly to/from the DOM. All element.remove() and element.append() should happen only after vimOverlay is removed, and when all the changes to its descendants are made, we then can add it back to the DOM. With this, the whole operation becomes quasi-instant.

hey im looking to implement this in my new pr #2860, its my understanding that you mean instead of keeping the vimOverlay in dom and appending / removing hundreds of keys, we instead append all these children before appending to document if that makes sense?