fix(css-map): remove outdated buddy feed header class #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunsetTechuila
changed the title
rxri
changed the title
rxri
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fix misaligned buddy feed header
Before version 1.2.0 buddy feed header has class
PJt6DU4NhGjz7fVCZjS7and its styles were stored inxpui-routes-buddy-feed.css, but starting with version 1.2.0 the class name has changed and its styles moved toxpui.css, so the styles inxpui-routes-buddy-feed.cssbecame obsolete and weren't apply anymore. Spicetify changes both the actual class name inxpui.cssand the obsolete ones inxpui-routes-buddy-feed.csstomain-buddyFeed-header, resulting in incorrect styling and misalignmentstock:
with spicetify applied:
since versions below 1.2.0 aren't supported anymore and in 1.2.0 it is different class name, I think this class can be removed from the map