New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(context-menu): catch error for items #2492

Merged

afonsojramos merged 1 commit into master from fix/content-menu-item-error

Aug 9, 2023

Member

kyrie25 commented Jul 27, 2023 •

edited

Loading

Uncaught error caused by one item affects all other items as the loop gets broken and the function never reaches the part where all items are prepended at once.
https://github.com/spicetify/spicetify-cli/blob/4393d2fb02d435f6e3ea4e0224553c95225d95c7/jsHelper/spicetifyWrapper.js#L1466


          fix(context-menu): catch error for items

4393d2f

kyrie25 requested review from rxri and afonsojramos

July 27, 2023 23:30

rxri approved these changes

View reviewed changes

afonsojramos approved these changes

View reviewed changes

afonsojramos merged commit 1219f43 into master

12 checks passed

afonsojramos deleted the fix/content-menu-item-error branch

August 9, 2023 09:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet