Support for relative width #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12rambau
reviewed
Apr 21, 2023
12rambau
reviewed
Apr 21, 2023
|
Actually, I have little to no knowledge of HTML and CSS. I just searched up how to do this specifically and mokey-patched the |
|
This would be great to land together with |
7 tasks
12rambau
requested changes
Nov 5, 2024
There was a problem hiding this comment.
@AnonymouX47 sorry for the long wait, all my OSS time was eaten up by another project. I would like to move forward with your PR, could you rebase it with the current main so I can merge it in the next release ?
- Change: The `width` option can now accept an integer percentage as its value. - Change: When `width` is relative, `height` is ignored and a warning is logged.
AnonymouX47
force-pushed
the
relative-width
branch
from
634ce98
to
f3163f9
Compare
- Fix: Correct the option usage example. - Change: Update the descriptions of `height` and `width` options. - Change: Use relative width in the option usage example.
AnonymouX47
force-pushed
the
relative-width
branch
from
f3163f9
to
a6a641f
Compare
|
All done, I believe. |
12rambau
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
widthoption can now accept an integer percentage as its value.widthis relative,heightis ignored and a warning is logged.heightandwidthoptions and uses relative width in the existing example.