fix(match/glob): e -> err

[milkpirate]

No description provided.

[CLAassistant]

All committers have signed the CLA.

[sagikazarmark]

Thanks for the PR.

I'm not sure that's enough though, because the err variable gets shadowed on the second line of the function.

I think the appropriate solution is dropping the variable names from the return declaration.

[milkpirate]

• Not really, the := in line 77 is necessary to declare fi, it will set the predeclared err as well. No shadowing (not like in L94).
• I did not remove the named returns, since if one does so, one has to explicitly return the corresponding err/nils as well as the actual values ([]string). I wanted to keep the impact minimal to increase the chance of getting the PR merged 😄

glob tests are fine with the changes:

=== RUN   TestGlob
    tarfs_test.go:408: glob: \*: glob ok
    tarfs_test.go:408: glob: *: glob ok
    tarfs_test.go:408: glob: sub\*: glob ok
    tarfs_test.go:408: glob: sub\testDir2\*: glob ok
    tarfs_test.go:408: glob: testDir1\*: glob ok
--- PASS: TestGlob (0.00s)

just not sure if they cover all cases.