allow absolute paths in BasePathFs when prefix is "" on windows#420
Open
DenKoren wants to merge 3 commits intospf13:masterfrom
Open
allow absolute paths in BasePathFs when prefix is "" on windows#420DenKoren wants to merge 3 commits intospf13:masterfrom
DenKoren wants to merge 3 commits intospf13:masterfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a special case, it is OK to allow absolute paths access when the
BasePathFs.pathis empty.Sometimes we need to provide access to full FS through BasePathFs type for code simplicity (to pass it to the functions, that want
BasePathFsspecific type, not justafero.FSinterface).