Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework search to filter instead of jumping to first one #16

Open
ptrcnull opened this issue Aug 2, 2024 · 1 comment
Open

Rework search to filter instead of jumping to first one #16

ptrcnull opened this issue Aug 2, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ptrcnull
Copy link

ptrcnull commented Aug 2, 2024

in case of artist names like firstArtist / secondArtist, you can't properly search for secondArtist as it just jumps to the first result; the search feature could instead filter the results

@spezifisch spezifisch added the enhancement New feature or request label Aug 4, 2024
@spezifisch
Copy link
Owner

You can press Return to get out of the search input field, then press 'n' to jump to the next match.
I like the idea of filtering the list though. Currently the artist list is a tview.List. The search just calls FindItems which makes the code pretty easy from our side. Filtering would probably best be implemented as an extension or patch to tview's List.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants