Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Search by genre #52

Open
xxxserxxx opened this issue Oct 4, 2024 · 0 comments
Open

[Feature] Search by genre #52

xxxserxxx opened this issue Oct 4, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@xxxserxxx
Copy link
Collaborator

xxxserxxx commented Oct 4, 2024

(Cut out of #26)

Do we use the same Search page? If so, do we add another Genre column to the search results (it gets maybe a little crowded)? This seems the most straightforward approach, and has the advantage of not adding yet another page. But it could also be implemented on the Browser page as a filter. I suspect this would be less than ideal, as I can imagine collection CDs where not all of the songs on the CDs are the same genre. Also, the Browser page is Artist-oriented, and many artists are cross-genre -- Shania Twain, for instance, has several times released the same song with a country/western orchestration, and with a rock orchestration, and they're clearly quite different genres. So she, and other artists (e.g. Carly Rae Jepsen) produce music in multiple different genres. So, I'm thinking maybe I'll try to squeeze it into the new Search page and we'll see if it's awful.

Other UI ideas are welcome.

Note the search[123] endpoints do not appear to (reliably?) search genres. There is a getSongsByGenre endpoint; weaving this into the Search page might take some finagling. I'm now wondering if we should consider modifications to the Browser page, s.t. users can cycle through "artists", "albums", and "genres" in the left pane. Alternatively, we could replace the Browser page with the Search page, and change the Browser's "search" to a filter function as requested in #16 . It'd allow us to reduce the number of pages that was recently increased by #40 (simplifying is good). It could also get rather fancy: if the Artist column is selected, then the albums and songs displayed would be for the selected artist; if the albums column were selected, then the artists and songs would be filtered (less useful, since album titles probably rarely overlap). Same with the songs, except there are probably more similarly titled songs. The downside would be that this would essentially end up loading the entire server song DB into the client memory. And it still doesn't address the genre issue, since we'd still have to add a genre column and squeeze the UI.

Anyway, some interesting options are available. I do kind of like the idea of having 3 columns on the Browser page and eliminating the Search page, whether or not we get fancy with navigation, because it (paradoxically) simplifies the UI and could even make navigation easier.

@spezifisch spezifisch added the enhancement New feature or request label Oct 13, 2024
xxxserxxx added a commit to xxxserxxx/stmps that referenced this issue Oct 18, 2024
xxxserxxx added a commit that referenced this issue Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants