Skip to content

Commit

Permalink
build: Remove test component of lib icu (facebookincubator#11826)
Browse files Browse the repository at this point in the history
Summary:
The test component of lib icu is not used in Velox. This pr simply removes it,
assuming there is no reason for keeping it.

Pull Request resolved: facebookincubator#11826

Reviewed By: xiaoxmeng

Differential Revision: D67119218

Pulled By: kgpai

fbshipit-source-id: a1a91e2e6c07ce699b2c23bf999ef0793070bd38
  • Loading branch information
PHILO-HE authored and facebook-github-bot committed Dec 12, 2024
1 parent 8d0d244 commit 63fcb27
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
3 changes: 1 addition & 2 deletions CMake/resolve_dependency_modules/icu.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ set(icu_components
i18n
io
uc
tu
test)
tu)

foreach(component ${icu_components})
add_library(ICU::${component} SHARED IMPORTED)
Expand Down
7 changes: 6 additions & 1 deletion CMake/resolve_dependency_modules/icu/FindICU.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,12 @@
# limitations under the License.
message("Using ICU - Bundled")
set(ICU_FOUND TRUE)
set(icu_components data i18n io uc tu test)
set(icu_components
data
i18n
io
uc
tu)
foreach(component icu_components)
set(ICU_${component}_FOUND TRUE)
endforeach()
3 changes: 1 addition & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -427,8 +427,7 @@ velox_resolve_dependency(
i18n
io
uc
tu
test)
tu)

set(BOOST_INCLUDE_LIBRARIES
atomic
Expand Down

0 comments on commit 63fcb27

Please sign in to comment.