Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tvOS support #187

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add tvOS support #187

wants to merge 10 commits into from

Conversation

dimazen
Copy link

@dimazen dimazen commented Apr 6, 2017

Adding tvOS support with Xcode 8.3

@dimazen
Copy link
Author

dimazen commented Apr 6, 2017

Not sure what exactly goes wrong, but it says that

Tests/Support/objc-build-scripts/cibuild: line 110:  1360 Abort trap: 6           xctool -project "$XCODEPROJ" $XCTOOL_OPTIONS "$@" 2>&1
ERROR: Unexpected action: test

I'm also not sure why to use Rakefile while we can go with .travis.yml similar to what Alamofire has.

@orta
Copy link
Member

orta commented Apr 6, 2017

Last time this was attempted it got stopped at some weird code signing issues - #175

I think switching to a similar .travis.yml as Alamofire may be simpler than the Rakefile approach WRT testing too.

@dimazen dimazen changed the title WIP: Add tvOS support Add tvOS support Apr 25, 2017
@dimazen
Copy link
Author

dimazen commented Apr 25, 2017

@orta Sorry, it took me longer than I would expect :)
So far I've added tvOS framework as well as setup unit tests execution for all of the supported targets in Debug + Release.

The only thing I'm not quite sure about is whether I need to add libExpecta-tvOS and do we need to run tests for iOS 8 and 9? I've skipped tests for iOS 8 / 9 due to the Travis CI issue travis-ci/travis-ci#7638.

Also do I have to remove rakefile and objc-build-scripts?

@orta
Copy link
Member

orta commented Apr 25, 2017

Never worry about your time WRT shipping OSS. Doesn't look like anyone is being blocked by your work.

I think as long as there is the ability to generate a library that can be consumed by others (@tonyarnold has been shipping those with releases) then I think that's really the only responsibility left in the Rakefile or the build scripts.

@dimazen
Copy link
Author

dimazen commented Apr 25, 2017

I ran (according to the Carthage guide)

carthage build --no-current-skip
carthage archive 

and got the following output (similar to what Tony Arnold did)
Expecta.framework.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants