Runtime attribute handling #430
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscartbeaumont
force-pushed
the
serde-properly
branch
from
e39a8b6 to
590f821
Compare
Closed
Merged
- Resolved conflicts in attribute system files - Removed deleted enum.rs file - Added Inflection enum to utils.rs - All tests already migrated to insta snapshots
- Remove calls to non-existent specta_serde::validate function - Fix comprehensive_serde_attrs example syntax - Remove duplicate Type derive on RenameToValue - Update validation to use process_for_serialization
Resolved conflicts in: - specta-typescript/src/legacy.rs: Kept simplified External-only enum representation from current branch while integrating flatten support from main - tests/tests/type_map.rs: Updated to use multi-line formatted snapshot from main
This was referenced Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
#[specta(...)]and core handlingTokenStream)specta-serdeshould runtime apply attributes for rename, etc.specta-serdeshould handle being phase-specficHook up phase-specific handling to Typescript exporterTreating these as an implementation detail till I can sort out some bigger concerns with duplicate types in the final bindings file.#[specta(skip_attribute = "bruh")]for skipping macro attributes as a workaround for future parsing issues.Maybe just remove Serde handling from the Typescript exporter but document is really well.not gonna do this for now but maybe in the future.Closes #258 & #232 & #332 & #229 & #328 & #114 & #402 & #395 & #132 & #130 & #22
TODO:
#[serde(skip)]fix looks broken cause it drops the&mut Vec<Attribute>specta_serdeshouldn't depend onspecta::internal#258specta_typescriptandspecta_serdespecta_serdepublic exports.