Skip to content

Close record set dialog on merge instead of reload#6371

Merged
CarolineDenis merged 2 commits intoproductionfrom
issue-6174
Apr 2, 2025
Merged

Close record set dialog on merge instead of reload#6371
CarolineDenis merged 2 commits intoproductionfrom
issue-6174

Conversation

@CarolineDenis
Copy link
Contributor

Fixes #6174

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

Open a data entry form
Enter data into a number of fields, relationships, etc.
Open the Record Sets dialog
Merge record sets

  • Verify the RS dialog closes without a reload

Triggered by 0ed618d on branch refs/heads/issue-6174
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify the RS dialog closes without a reload

Looks good!

@emenslin emenslin requested a review from a team April 1, 2025 15:24
Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify the RS dialog closes without a reload

Looks good! No reload.

@CarolineDenis CarolineDenis merged commit 2df6052 into production Apr 2, 2025
12 checks passed
@CarolineDenis CarolineDenis deleted the issue-6174 branch April 2, 2025 17:17
@github-project-automation github-project-automation bot moved this from 📋Back Log to ✅Done in General Tester Board Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Merging record sets deletes unsaved data

5 participants