Skip to content

Disable batch edit for spAuditLog#6325

Merged
CarolineDenis merged 2 commits intoproductionfrom
issue-6323
Mar 17, 2025
Merged

Disable batch edit for spAuditLog#6325
CarolineDenis merged 2 commits intoproductionfrom
issue-6323

Conversation

@CarolineDenis
Copy link
Contributor

Fixes #6323

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • Go to queries
  • Select 'Sp audit log' as the base table
  • Press query
  • Verify that batch edit button is disabled
  • Go to queries
  • Select another table as the base table
  • Press query
  • Verify that batch edit button is enabled when it should

@CarolineDenis CarolineDenis requested review from a team and acwhite211 March 14, 2025 21:02
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify that batch edit button is disabled
  • Verify that batch edit button is enabled when it should

Batch edit is disabled if you add fields to the audit log query but it is still enabled when no fields are mapped

03-14_16.23.mp4

@github-project-automation github-project-automation bot moved this from 📋Back Log to Dev Attention Needed in General Tester Board Mar 14, 2025
@CarolineDenis CarolineDenis requested review from a team and emenslin March 17, 2025 13:37
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify that batch edit button is disabled
  • Verify that batch edit button is enabled when it should

Looks good!

@emenslin emenslin requested a review from a team March 17, 2025 17:05
@CarolineDenis CarolineDenis merged commit 47d3d1c into production Mar 17, 2025
12 checks passed
@CarolineDenis CarolineDenis deleted the issue-6323 branch March 17, 2025 17:37
@github-project-automation github-project-automation bot moved this from Dev Attention Needed to ✅Done in General Tester Board Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Can batch edit audit log

4 participants