Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix continuous integration DCO sign-off check #765

Draft
wants to merge 1 commit into
base: development/v2.3
Choose a base branch
from

Conversation

seabass-labrax
Copy link
Contributor

This commit introduces to this repository the same DCO check as in the SPDX Canonical Serialisation specification repository (with some minor modifications).

Some recent pull requests have been failing the automated checks (#758 for instance). The intention of this commit is to replace the 'GitHub App' DCO check with the dco-check open source Python package, which does not fail for such pull requests.

After merging this pull request, the commit will need to be merged/rebased into the other branches on which checks should be run. Also, the DCO GitHub App will need to be disabled by a SPDX organisation admin who holds sufficient GitHub permissions.

Signed-off-by: Sebastian Crane <[email protected]>

@seabass-labrax
Copy link
Contributor Author

These instructions might be helpful for disabling the existing DCO check: https://docs.github.com/en/developers/apps/managing-github-apps/deleting-a-github-app

@seabass-labrax seabass-labrax marked this pull request as draft July 27, 2022 12:25
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seabass-labrax - This looks like a good alternative to the current check.

@kestewart
Copy link
Contributor

@goneall - is this still moving forward, or should it be closed now?

@goneall
Copy link
Member

goneall commented Apr 20, 2024

@kestewart - we need to fix the DCO signoff - let's leave this open - it's marked as a draft, so I'll need to do a review if the PR to see if it is ready. Have a few higher priority SPDX items to take care of first.

@goneall goneall added this to the 3.1 milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants